Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #17375, comment 36


Ignore:
Timestamp:
05/08/2015 07:49:39 PM (10 years ago)
Author:
channeleaton
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #17375, comment 36

    initial v1  
    11Replying to [comment:35 nacin]:
    2 > Replying to [comment:15 nacin]:
    3 > > Any changes here need sign-off by the security team before continuing.
    4 >
    52> I am almost positive we cannot make this change without directly adding an arbitrary code execution vulnerability.
    6 >
    7 > = *DO NOT COMMIT UNDER ANY CIRCUMSTANCES.* =
    83
    94I'm just trying to understand what's going on with the change. Is it the regex that creates the vulnerability? If not, we're basically just adding another key by which `is_serialized()` will return true. If normal objects are already processed as true through this function, is the vulnerability not already present?