WordPress.org

Make WordPress Core

Opened 10 years ago

Closed 10 years ago

#17385 closed defect (bug) (fixed)

Post time is missing in Twenty Eleven

Reported by: peaceablewhale Owned by: nacin
Milestone: 3.2 Priority: normal
Severity: normal Version: 3.2
Component: Bundled Theme Keywords: has-patch
Focuses: Cc:

Description

Twenty Eleven only shows post date, but the time is missing.

Attachments (8)

17385.diff (12.9 KB) - added by sorich87 10 years ago.
17385.escape-output.diff (12.8 KB) - added by mfields 10 years ago.
escacpe output. as mentioned in #17563
author-link-hiding.diff (2.1 KB) - added by iandstewart 10 years ago.
17385.2.diff (20.7 KB) - added by mikeschroder 10 years ago.
Combination of Newest patches here and #17563, with additional esc_url as appropriate
17385.3.diff (20.7 KB) - added by mikeschroder 10 years ago.
Added rel="author" to twentyeleven_posted_on
17385.4.diff (21.1 KB) - added by iandstewart 10 years ago.
Add .by-author class to the footer of content-image.php
17385.5.diff (21.0 KB) - added by iandstewart 10 years ago.
Use the less cryptic display:none to hide author bits
17385.6.diff (1.1 KB) - added by aaroncampbell 10 years ago.

Download all attachments as: .zip

Change History (25)

#1 @ocean90
10 years ago

  • Cc lancewillett iandstewart added
  • Keywords needs-patch added
  • Milestone changed from Awaiting Review to 3.2

It was displayed via the title attribute in Twenty Ten.

To avoid code duplication we should also create twentyeleven_posted_on() (see twentyten_posted_on()).

@sorich87
10 years ago

#2 @sorich87
10 years ago

  • Keywords has-patch added; needs-patch removed

#3 @ocean90
10 years ago

  • Owner set to nacin
  • Status changed from new to reviewing

Thanks for the patch!

#4 @iandstewart
10 years ago

The patch looks good to me.

Last edited 10 years ago by iandstewart (previous) (diff)

@mfields
10 years ago

escacpe output. as mentioned in #17563

#5 @iandstewart
10 years ago

author-link-hiding.diff builds on the above patches and adds support for only displaying author links if ismulti_author() returns true.

#6 @nacin
10 years ago

  1. Would display: none make more sense and be less cryptic?
  1. Why not just hide author in PHP using is_multi_author()?

#7 @iandstewart
10 years ago

Display none would be less cryptic and PHP simpler but I'd prefer to keep it there for machines and bots to read. I'm open to either though if it means hiding the name for single-author blogs.

#8 @westi
10 years ago

  • Component changed from Themes to Bundled Theme

#9 @westi
10 years ago

We shouldn't hide in PHP but using CSS so a child theme can easily override the decision.

#10 @nacin
10 years ago

  • Keywords needs-refresh added

Good call on the CSS. Sounds like we just need a patch refresh here. display:none + implements the new function everywhere.

@mikeschroder
10 years ago

Combination of Newest patches here and #17563, with additional esc_url as appropriate

#11 @ryan
10 years ago

Seems that twentyeleven_posted_on() is missing rel="author"

@mikeschroder
10 years ago

Added rel="author" to twentyeleven_posted_on

#12 @mikeschroder
10 years ago

  • Cc mike.schroder@… added
  • Keywords needs-refresh removed

#13 @iandstewart
10 years ago

The CSS author hiding if ! is_multi_author() is working as expected for me. As is, resetting with CSS in a child theme.

Last edited 10 years ago by iandstewart (previous) (diff)

@iandstewart
10 years ago

Add .by-author class to the footer of content-image.php

@iandstewart
10 years ago

Use the less cryptic display:none to hide author bits

#14 @nacin
10 years ago

In [18244]:

Twenty Eleven: escaping frenzy, hide authors if a single author blog. props DH-Shredder, props iandstewart, see #17385, fixes #17563.

#16 @nacin
10 years ago

In [18257]:

Remove extra </a>. props aaroncampbell. see #17385.

#17 @ryan
10 years ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

Any more escaping can be done on the audit ticket, #17748.

Note: See TracTickets for help on using tickets.