Opened 14 years ago
Closed 13 years ago
#17385 closed defect (bug) (fixed)
Post time is missing in Twenty Eleven
Reported by: | peaceablewhale | Owned by: | nacin |
---|---|---|---|
Milestone: | 3.2 | Priority: | normal |
Severity: | normal | Version: | 3.2 |
Component: | Bundled Theme | Keywords: | has-patch |
Focuses: | Cc: |
Description
Twenty Eleven only shows post date, but the time is missing.
Attachments (8)
Change History (25)
#1
@
13 years ago
- Cc lancewillett iandstewart added
- Keywords needs-patch added
- Milestone changed from Awaiting Review to 3.2
#5
@
13 years ago
author-link-hiding.diff builds on the above patches and adds support for only displaying author links if ismulti_author() returns true.
#6
@
13 years ago
- Would display: none make more sense and be less cryptic?
- Why not just hide author in PHP using is_multi_author()?
#7
@
13 years ago
Display none would be less cryptic and PHP simpler but I'd prefer to keep it there for machines and bots to read. I'm open to either though if it means hiding the name for single-author blogs.
#9
@
13 years ago
We shouldn't hide in PHP but using CSS so a child theme can easily override the decision.
#10
@
13 years ago
- Keywords needs-refresh added
Good call on the CSS. Sounds like we just need a patch refresh here. display:none + implements the new function everywhere.
@
13 years ago
Combination of Newest patches here and #17563, with additional esc_url as appropriate
#13
@
13 years ago
The CSS author hiding if ! is_multI_author() is working as expected for me. As is, resetting with CSS in a child theme.
#15
@
13 years ago
I think [18244] introduced an extra </a> in wp-content/themes/twentyeleven/content-image.php on line 35
It was displayed via the title attribute in Twenty Ten.
To avoid code duplication we should also create twentyeleven_posted_on() (see twentyten_posted_on()).