WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 2 years ago

Last modified 2 years ago

#17390 closed enhancement (fixed)

Tiddly tiny little Settings screen tweaks

Reported by: johnbillion Owned by: nacin
Milestone: 3.4 Priority: normal
Severity: minor Version:
Component: UI Keywords: has-patch commit
Focuses: Cc:

Description

It bugs me when the description texts wrap off the edge on the Settings screens. Be nice if they had a linebreak after the input so they were a little more inline.

Attachments (1)

17390.patch (5.8 KB) - added by johnbillion 3 years ago.

Download all attachments as: .zip

Change History (9)

johnbillion3 years ago

comment:1 johnbillion3 years ago

  • Keywords has-patch added

Patch

comment:2 SergeyBiryukov3 years ago

  • Keywords ui-feedback added

comment:3 jane2 years ago

  • Component changed from Administration to UI
  • Keywords ui-feedback removed
  • Milestone changed from Awaiting Review to 3.4

I haven't looked at the patch applied, but the description sounds reasonable. Fine by me (reserving right to change mind if once live it doesn't look good. :) )

comment:4 nacin2 years ago

  • Keywords commit added

Committing so Jane can see.

comment:5 nacin2 years ago

Would it make sense to just make span.description display:block and/or convert them to div's?

comment:6 helenyhou2 years ago

Wouldn't a p make sense for these?

comment:7 nacin2 years ago

  • Owner set to nacin
  • Resolution set to fixed
  • Status changed from new to closed

In [20605]:

Add line breaks before most form field descriptions (the italicized gray text on General Settings and other screens). props johnbillion, helenyhou, fixes #17390.

comment:8 nacin2 years ago

I used <br/><span class="description"> when it followed a textarea, as it caused extra margins that I couldn't track down.

Note: See TracTickets for help on using tickets.