WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 4 years ago

#17393 closed defect (bug) (fixed)

Lost WYSIWYRG in editor-style.css - twenty eleven

Reported by: bi0xid Owned by: iandstewart
Milestone: 3.2 Priority: normal
Severity: normal Version: 3.2
Component: Editor Keywords: has-patch
Focuses: Cc:

Description

Working with twenty eleven we realized that it is absolutely elastic. Absolutely means that the editor is no more the reflection of the published one.

In its actual form, it have problems showing images in editor as well.

Simple patch attached to correct this.

Attachments (2)

twentyeleven_editor_patch.diff (607 bytes) - added by bi0xid 4 years ago.
Twenty Eleven editor patch (max-width)
twentyeleven_editor_patch.patch (607 bytes) - added by bi0xid 4 years ago.
Twenty Eleven editor patch (max-width)

Download all attachments as: .zip

Change History (7)

comment:1 follow-up: @nacin4 years ago

  • Milestone changed from Awaiting Review to 3.2
  • Type changed from enhancement to defect (bug)

Per earlier discussion in IRC I believe this was supposed to happen.

@bi0xid4 years ago

Twenty Eleven editor patch (max-width)

@bi0xid4 years ago

Twenty Eleven editor patch (max-width)

comment:2 in reply to: ↑ 1 @bi0xid4 years ago

Replying to nacin:

Per earlier discussion in IRC I believe this was supposed to happen.

It have a so simple solution. Max-width allows the theme to continue being elastic and your editors have no problems formatting their text and images.

I think that this is a regresion and it goes against the editors.

BTW, I have some problems with the patch. It does not color itself. Sorry for the duplicity.

comment:3 follow-up: @iandstewart4 years ago

The intention was to keep the editor content fluid. A constrained width for the visual editor seems to tend to be seen as a bug. Recommending wontfix.

comment:4 in reply to: ↑ 3 @bi0xid4 years ago

Replying to iandstewart:

The intention was to keep the editor content fluid. A constrained width for the visual editor seems to tend to be seen as a bug. Recommending wontfix.

I like a fluid content too. With this option, if it is smaller it will be fluid. Simply I think losing one of the changes that were more appreciated for users (edit their stuff and see in real time how it will be when published) is not a good decision.

comment:5 @iandstewart4 years ago

  • Owner set to iandstewart
  • Resolution set to fixed
  • Status changed from new to closed

In [18121]:

Twenty Eleven: editor-style should have max-width; Props bi0xid; Fixes #17393 #17649; See #17644

Note: See TracTickets for help on using tickets.