WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 3 years ago

#17402 closed defect (bug) (fixed)

Old version dates for wp-logo.png images uses cached images on 3.2 upgrade

Reported by: zekeweeks Owned by: nacin
Milestone: 3.2 Priority: normal
Severity: normal Version: 3.2
Component: Administration Keywords: has-patch
Focuses: Cc:

Description

I upgraded a 3.1 install to 3.2 and noticed that wp-logo.png displays 3.1's old 32px version in the new Admin header. Refreshing browser cache fixes it for users, but it looks like colors-fresh.css and colors-classic.css append ?ver=20100531 and ?ver=20101102 respectively to the file URL (probably to avoid this problem?)

Looks like the 16px files were last updated on 2011-05-04, so I've attached a patch making use of that date. (This is my first patch submitted to WordPress, so please let me know if this should be done differently. :-) )

Attachments (1)

patch.diff (145.8 KB) - added by zekeweeks 3 years ago.
Updated dates in colors-fresh.css and colors-classic.css

Download all attachments as: .zip

Change History (4)

zekeweeks3 years ago

Updated dates in colors-fresh.css and colors-classic.css

comment:1 nacin3 years ago

  • Milestone changed from Awaiting Review to 3.2
  • Owner set to nacin
  • Status changed from new to accepted

comment:2 nacin3 years ago

Thanks for the patch - one note, don't patch the compressed files. We handle those on commit. Keeps patches fresher (this one didn't apply due to unrelated changes in the file since then) and allows us to verify that things match.

Congrats on patch #1!

Version 0, edited 3 years ago by nacin (next)

comment:3 nacin3 years ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In [17905]:

Update wp-logo.png version number. props zekeweeks, fixes #17402.

Note: See TracTickets for help on using tickets.