Make WordPress Core

Opened 4 years ago

Closed 4 years ago

#17415 closed defect (bug) (fixed)

Twenty Eleven: Selected layout not working in the showcase template

Reported by: rubenw Owned by: iandstewart
Milestone: 3.2 Priority: normal
Severity: normal Version: 3.2
Component: Bundled Theme Keywords: has-patch
Focuses: Cc:


I am running the WordPress 3.2-beta1 and am playing around with the new Twenty Eleven theme. When having selected the following:

  • Startpage: static page = Myhomepage (which uses the template: Showcase template)
  • Showcase sidebar: Filled with 'Twenty Eleven Ephemara'
  • Theme options: Layout = Content on left (with color scheme: light)

The showcase sidebar is shown on the the left, and this is where I expected to see the content as this has been selected in the theme options.

Attachments (1)

17415.patch (603 bytes) - added by ocean90 4 years ago.

Download all attachments as: .zip

Change History (9)

comment:1 follow-up: @ocean904 years ago

  • Cc lancewillett iandstewart added
  • Keywords needs-patch added
  • Milestone changed from Awaiting Review to 3.2

Screenshot with content on right: http://d.pr/vpY5

Screenshot with content on left: http://d.pr/37Is

I think the selected layout should be ignored.

comment:2 @iandstewart4 years ago

Our intention with Twenty Eleven was for the showcase template to ignore the layout settings. With so much going on, it seemed best that it's layout was specific and set.

comment:3 in reply to: ↑ 1 @ramiy4 years ago

Replying to ocean90:

I think the selected layout should be ignored.

if someone selects a layout, he does not expect the theme to ignore it.

comment:4 @iandstewart4 years ago

By ignore, I mean, the showcase is a more specific layout that already overrides any page template and it feels right that it would override the global setting for layout in Appearance > Theme Options. It's easily modified in a child theme for those looking for further customization.

Version 0, edited 4 years ago by iandstewart (next)

@ocean904 years ago

comment:5 @ocean904 years ago

  • Keywords has-patch added; needs-patch removed

Simple patch.

comment:6 @westi4 years ago

  • Component changed from Themes to Bundled Theme

comment:7 @westi4 years ago

  • Owner set to iandstewart
  • Status changed from new to assigned

comment:8 @iandstewart4 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In [18168]:

Twenty Eleven: correct layout bug with showcase template and alt layout option; Props ocean90; Fixes #17415

Note: See TracTickets for help on using tickets.