Authors see misleading links in media library

[johnbillion]

Visit the Media Library while logged in as an Author and you'll see each media item's title is a link (with a title attribute of "Edit [title]"), but this link takes you straight back to the media library as you don't have the required capability to edit media items.

Affects 3.1 and trunk.

[solarissmoke]

Same applies for the link on the image thumbnail, the Attach link, and the link to edit the parent post (if attached). See patch.

[solarissmoke]

Check permissions before showing various edit links in media library

[johnpbloch]

Tested on trunk. Works fine for me.

[kirasong]

A bit of formatting to make the code easier to read

[kirasong]

Tested, and still works for me on trunk. Uploaded version with a bit of formatting cleanup if desired.

[kurtpayne]

Bug fixed by 17419.formatted.1.diff

[kurtpayne]

Looks like there's a bug when mixing images that are owned by an author and images that are not owned by an author. For example, see 17419.bug.png​. The user "author" uploaded an image, futurama_14, that shows a checkbox and the appropriate edit, delete, and attach links. However, the "author" user is also given checkboxes and attach links for other images.

It looks like the $post object is being reset by ​The Loop in display_rows() function. Patch 17419.formatted.1.diff​ should fix this by resetting $user_can_edit after the loop.

Let me know if I missed anything!

[olleicua]

tested on Revision #19107. Before patch the attach link was displayed, after it was not. Looks pretty solid. Also some nice cleanup to make the code more readable.

+1

[kcristiano]

tested on Revision 19193. Works as described

[nacin]

17419.formatted.1.diff​ looks good here.

[edwardw]

Tested on r19236 and works as expected.

[ryan]

In [19252]:

Check caps when showing media edit and attach links. Clean up formatting. Props kurtpayne, DH-Shredder, solarissmoke. fixes #17419