Update star.gif file

[tillkruess]

With the change of the admin ui layout in 3.2, the old star.gif looks funky. See screenshot.

[hebbet]

the white background looks not so professional.

[ocean90]

We need an updated ​star.gif with transparent background. Background color from star.gif is #fff, background color of the table is #f9f9f9.

[hebbet]

current image is OK for blue admin.

[ocean90]

In blue style the background color is #fff. Also we can't use a transparent image because of the style behind the stars.

Related/Duplicate: #10148

[chexee]

possible replacement?

[chexee]

Attached a screenshot of a patch I'm working on. Any feedback on that star? From the way the stars work, we'll have to make one for the blue version and one for the grey.

[travisnorthcutt]

Looks good, except that IMO a symmetrical one would look better. I say that without seeing the two side by side, of course.

[nacin]

What needs to happen here? What's the absolute minimum we need to do? Replace an image?

[tillkruess]

The blue admin theme has #fff as background color and the gray admin theme #f9f9f9. We either need to use two different star.gif files for each of them, or we change background-color of .widefat in colors-classic.css from #fff to #f9f9f9.

[chexee]

new star with #f9f9f9 background.

[chexee]

Replying to travisnorthcutt:

Looks good, except that IMO a symmetrical one would look better. I say that without seeing the two side by side, of course.

I'll try a more symmetrical one. This one, obviously, is more like a star as you would draw it (or the type on an American flag). Uploading the png of this one.

I was going to write a patch, but the star image is in a php file and if that needs to change between color schemes, I probably shouldn't touch it :]

[dd32]

minimum needed here:

• new image for Gray theme (Already attached here), has a #f9f9f9 background. Existing star.gif (#fff) in core is good for Blue theme.
• Alteration needed in the code is to replace the 15 instances of echo admin_url('images/star.gif'); with some kind of conditional, if Gray theme use images/gray-star.png, else, use star.gif. Not sure if we have a Colour-scheme helper function we can use here?

Will investigate point 2 tomorrow.

Notes:

• Can't use CSS thanks to these being actual <img>'s (can't change that either)
• New png looks much less pixelated and smooth edged, nice compared to the old one

[chexee]

Star with #fff background

[chexee]

Uploaded a .png for classic (blue version). Still refining a symmetrical star option. I'll upload some later, but the anti-aliased stars are a little nicer and jive a little better with the icon styles.

[dd32]

Can we also get an original copy of the source file if one exists? (For example, a higher resolution psd?) It'll make it easier for future colour changes that way as we can re-generate a new image with the correct background colours without having to use a new design.

[dd32]

Turns out, out of the 3 places in core star.gif was used, only one location needs changing to #f9f9f9 and only when using the fresh colour scheme, the list tables.

If there's no objections to these, I'll commit the ones that are on the ticket here tomorrow, It'll get the PHP changes needed out of the way. The current ones here are the same design(size & angle wise) as the ones in core, just a bit cleaner which fits the overall design better.

I'm using them locally and it seems fine to me.

[dd32]

In [18318]:

Add new star.gif replacement with a Grey background (& White counterpart). Props chexee for star icons. Fixes #17428