WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 3 years ago

#17428 closed enhancement (fixed)

Update star.gif file

Reported by: tillkruess Owned by: dd32
Milestone: 3.2 Priority: normal
Severity: normal Version: 3.2
Component: Graphic Design Keywords: needs-patch ui-feedback
Focuses: Cc:

Description

With the change of the admin ui layout in 3.2, the old star.gif looks funky. See screenshot.

Attachments (4)

star-gif.png (8.8 KB) - added by tillkruess 3 years ago.
Screen shot 2011-06-12 at 4.20.47 PM.png (9.9 KB) - added by chexee 3 years ago.
possible replacement?
star.png (625 bytes) - added by chexee 3 years ago.
new star with #f9f9f9 background.
star-classic.png (611 bytes) - added by chexee 3 years ago.
Star with #fff background

Download all attachments as: .zip

Change History (21)

tillkruess3 years ago

comment:1 tillkruess3 years ago

  • Cc me@… added

comment:2 ocean903 years ago

  • Keywords needs-patch ui-feedback added

comment:3 ocean903 years ago

  • Type changed from defect (bug) to enhancement

comment:4 hebbet3 years ago

the white background looks not so professional.

Last edited 3 years ago by hebbet (previous) (diff)

comment:5 ocean903 years ago

  • Keywords ui-feedback removed
  • Milestone changed from Awaiting Review to 3.2

We need an updated star.gif. Background color from star.gif is #fff, background color of the table is #f9f9f9.

Version 1, edited 3 years ago by ocean90 (previous) (next) (diff)

comment:6 hebbet3 years ago

current image is OK for blue admin.

comment:7 ocean903 years ago

In blue style the background color is #fff. Also we can't use a transparent image because of the style behind the stars.

Related/Duplicate: #10148

Last edited 3 years ago by ocean90 (previous) (diff)

chexee3 years ago

possible replacement?

comment:8 follow-up: chexee3 years ago

Attached a screenshot of a patch I'm working on. Any feedback on that star? From the way the stars work, we'll have to make one for the blue version and one for the grey.

comment:9 in reply to: ↑ 8 ; follow-up: travisnorthcutt3 years ago

  • Cc travis@… added

Looks good, except that IMO a symmetrical one would look better. I say that without seeing the two side by side, of course.

comment:10 nacin3 years ago

What needs to happen here? What's the absolute minimum we need to do? Replace an image?

comment:11 tillkruess3 years ago

The blue admin theme has #fff as background color and the gray admin theme #f9f9f9. We either need to use two different star.gif files for each of them, or we change background-color of .widefat in colors-classic.css from #fff to #f9f9f9.

chexee3 years ago

new star with #f9f9f9 background.

comment:12 in reply to: ↑ 9 chexee3 years ago

Replying to travisnorthcutt:

Looks good, except that IMO a symmetrical one would look better. I say that without seeing the two side by side, of course.

I'll try a more symmetrical one. This one, obviously, is more like a star as you would draw it (or the type on an American flag). Uploading the png of this one.

I was going to write a patch, but the star image is in a php file and if that needs to change between color schemes, I probably shouldn't touch it :]

comment:13 dd323 years ago

minimum needed here:

  • new image for Gray theme (Already attached here), has a #f9f9f9 background. Existing star.gif (#fff) in core is good for Blue theme.
  • Alteration needed in the code is to replace the 15 instances of echo admin_url('images/star.gif'); with some kind of conditional, if Gray theme use images/gray-star.png, else, use star.gif. Not sure if we have a Colour-scheme helper function we can use here?

Will investigate point 2 tomorrow.

Notes:

  • Can't use CSS thanks to these being actual <img>'s (can't change that either)
  • New png looks much less pixelated and smooth edged, nice compared to the old one

chexee3 years ago

Star with #fff background

comment:14 chexee3 years ago

Uploaded a .png for classic (blue version). Still refining a symmetrical star option. I'll upload some later, but the anti-aliased stars are a little nicer and jive a little better with the icon styles.

comment:15 dd323 years ago

Can we also get an original copy of the source file if one exists? (For example, a higher resolution psd?) It'll make it easier for future colour changes that way as we can re-generate a new image with the correct background colours without having to use a new design.

comment:16 dd323 years ago

  • Keywords ui-feedback added

Turns out, out of the 3 places in core star.gif was used, only one location needs changing to #f9f9f9 and only when using the fresh colour scheme, the list tables.

If there's no objections to these, I'll commit the ones that are on the ticket here tomorrow, It'll get the PHP changes needed out of the way. The current ones here are the same design(size & angle wise) as the ones in core, just a bit cleaner which fits the overall design better.

I'm using them locally and it seems fine to me.

comment:17 dd323 years ago

  • Owner set to dd32
  • Resolution set to fixed
  • Status changed from new to closed

In [18318]:

Add new star.gif replacement with a Grey background (& White counterpart). Props chexee for star icons. Fixes #17428

Note: See TracTickets for help on using tickets.