"show on screen" appears twice

[arena]

see images attached

[scribu]

Confirmed.

[aaroncampbell]

It's like that on my 3.1 installs as well.

[aaroncampbell]

It also affects the comments and the plugins screens. The text is the same, but it is given context for translation:

<h5><?php _ex('Show on screen', 'Metaboxes') ?></h5>
...
<h5><?php _ex('Show on screen', 'Screen Options') ?></h5>

I'm honestly not sure if this one is valid. I suppose we could come up with different text like "Number per page", but I'm not sure it's really a problem the way it is.

[scribu]

If the text is the same in both cases, then it's not descriptive enough.

We either make it more descriptive or only show it once.

[westi]

I'm sure we have fixed a similar bug in the past.

Maybe something has returned :(

[arena]

Not sure 'Boxes to show' will fit for columns !!??

[scribu]

If you take a closer look at the patch, you will see that there's a different string for columns.

[scribu]

Replying to westi:

I'm sure we have fixed a similar bug in the past.

Maybe something has returned :(

The context was introduced in [14636], so it was never really fixed, in this sense.

[westi]

Oh yeah now I remember.

This code is so ghetto and fragile and just needs a rewrite from scratch with a proper api so it doesn't do wierd stuff :(

[scribu]

Sure, but until then, we can fix the simple stuff.

[dcowgill]

Updated diff and fixed typo.

[dcowgill]

Tested and all looks good.

[scribu]

Re 17431.2.diff​: what typo?

[dd32]

Re 17431.2.diff : what typo?

Extra whitespace in the final string.

[scribu]

Ah, finally managed to see it, on line 1793.

Note that the new patch, on line 1766, has an extra space after : and another one at EOL.

[dcowgill]

Removing extra white spaces.

[dcowgill]

Corrected version.

[azaozz]

Best would be to gather all the output HTML in a var and if not empty output "Show on screen" followed by the rest of the HTML.

[jane]

It should only be there once per screen, but it's not really a big deal. Removing ux-feedback tag and letting the devs decide how to handle it.

[nacin]

Given the changes to WP_Screen, these patches are stale. Here's a new one.

[nacin]

In [19943]:

Only show 'Show on screen' once in screen options. fixes #17431.