WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 3 years ago

#17443 closed defect (bug) (fixed)

Passing by reference is not needed for admin_bar_menu action any longer

Reported by: hakre Owned by:
Milestone: 3.3 Priority: normal
Severity: normal Version: 3.2
Component: General Keywords: has-patch
Focuses: Cc:

Description

Passing by reference is not needed for admin_bar_menu action any longer.

Attachments (3)

17443.patch (482 bytes) - added by hakre 4 years ago.
switch to do_action.
17443.2.patch (1.4 KB) - added by hakre 4 years ago.
Some more related un-needed references.
17443.3.patch (1.7 KB) - added by hakre 4 years ago.
Useless to cast.

Download all attachments as: .zip

Change History (8)

@hakre4 years ago

switch to do_action.

comment:1 @hakre4 years ago

Related: #16767

comment:2 @hakre4 years ago

The callbacks didn't expect a pass by reference already.

@hakre4 years ago

Some more related un-needed references.

@hakre4 years ago

Useless to cast.

comment:3 @hakre4 years ago

Additionally there is no need to cast to an array as foreach does objects, see PHP 5 Object Iteration.

comment:4 @hakre4 years ago

Related: #16661

comment:5 @ryan3 years ago

  • Milestone changed from Awaiting Review to 3.3
  • Resolution set to fixed
  • Status changed from new to closed

Fixed during 3.3

Note: See TracTickets for help on using tickets.