WordPress.org

Make WordPress Core

Opened 7 years ago

Last modified 3 years ago

#17451 accepted enhancement

Unify plugin update notices and include changelog data

Reported by: dempsey Owned by: nacin
Milestone: Future Release Priority: normal
Severity: normal Version:
Component: Upgrade/Install Keywords: needs-patch dev-feedback needs-nacin
Focuses: Cc:

Description

Currently the after_plugin_row hook is only used on plugins.php which is used by the Changelogger plugin to show plugin changelogs inline.

If the hook is also added to the bottom of list_plugin_updates in update_core.php then changelogs could also be displayed on that page too.

It's only a single line change so not sure how/if it's worth me attaching a patch for this?

Attachments (2)

after_updates_row.diff (1.2 KB) - added by dempsey 7 years ago.
Proposed patch.
upgrade-notice.17451.diff (903 bytes) - added by stephenharris 2 years ago.
Add upgrade notice to plugins page

Download all attachments as: .zip

Change History (24)

#1 @scribu
7 years ago

Yes, it would be worth attaching a patch, but I don't think naming the hook 'after_plugin_row' is a good idea. That hook is meant for the plugins page and can be used for other things besides showing changelogs.

@dempsey
7 years ago

Proposed patch.

#2 @dempsey
7 years ago

I've added a patch with the proposed action names of after_plugin_updates_row and after_theme_updates_row

#3 @dempsey
7 years ago

  • Summary changed from Add after_plugin_row hook to Updates Page. to Add after_*_updates_row hook to Updates Page.

#4 @dempsey
7 years ago

  • Keywords has-patch added

#5 @nacin
6 years ago

  • Milestone changed from Awaiting Review to 3.3
  • Owner set to nacin
  • Status changed from new to accepted

Good start. Going to try to standardize some things here. Aside from this, the update notices should also appear on plugins.php.

#6 @Alphawolf
6 years ago

Cool.

I am the author of the Changelogger plugin and adding that hook would be a huge improvement for the plugin to show information before an (plugin) update process.

Thanks for suggesting, dempsey!

#7 @nacin
6 years ago

  • Summary changed from Add after_*_updates_row hook to Updates Page. to Unify plugin update notices and include changelog data

Shifting this to a task.

Let's plan to pull in the update notices to plugins.php and bring Changelogger into core. Initial patches welcome. The idea would be that we can show a changelog not just before updating, but after as well (probably on the upgrade screen itself). If a changelog was too long, we'd have a way to collapse it. I might end up re-using the plugins list table here.

I'm tempted to split off how we handle DISALLOW_FILE_MODS as well. Right now, that kills update_* caps, but I think a better use case would be this: you want to manage your stuff via Subversion, but wouldn't mind seeing the notices if you can otherwise -- you just don't want to allow the notices to appear. Currently, everything gets blocked out, which might make sense if someone was maintaining an install for a client, but if that were the case, they'd possibly just hide the Plugins screen anyway. DISALLOW_FILE_MODS should handle security implications, not notification ones. Ryan, thoughts?

#8 @SergeyBiryukov
6 years ago

  • Keywords needs-patch added; has-patch removed

#9 @jane
6 years ago

  • Milestone changed from 3.3 to Future Release

Punting because we are at freeze and there's not a patch ready for commit. Revisit early 3.4.

#10 @Ipstenu
6 years ago

  • Cc ipstenu@… added

#11 @helenyhou
6 years ago

  • Cc helenyhou added

#12 @sabreuse
6 years ago

  • Cc sabreuse@… added

#13 @sirzooro
6 years ago

  • Cc sirzooro added

3.4 has just started, so please take a look on this :)

#14 @SergeyBiryukov
6 years ago

  • Milestone changed from Future Release to 3.4

#15 @jaredatch
6 years ago

  • Cc jared@… added

#16 @hameedullah
6 years ago

  • Cc hameedullah added

#17 @Mamaduka
6 years ago

  • Cc georgemamadashvili@… added

#18 @SergeyBiryukov
6 years ago

  • Milestone changed from 3.4 to Future Release

#19 @dempsey
5 years ago

Any chance of getting this into 3.5? What needs doing?

#20 @dempsey
5 years ago

How about into 3.6 as we're in the early stages? What needs to be done?

#21 @SergeyBiryukov
5 years ago

I guess comment:7 summarizes what needs to be done.

#22 @chriscct7
3 years ago

  • Keywords dev-feedback needs-nacin added

@nacin Did you still want to merge Changelogger?

@stephenharris
2 years ago

Add upgrade notice to plugins page

Note: See TracTickets for help on using tickets.