WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 3 years ago

#17484 closed defect (bug) (fixed)

r17943 breaks plugins that rearrange the admin menu

Reported by: johnjamesjacoby Owned by: azaozz
Milestone: 3.2 Priority: high
Severity: major Version:
Component: UI Keywords: has-patch
Focuses: Cc:

Description

r17943 affects Jetpack, BuddyPress, and bbPress. See #17324.

It removes unique identifiers of the core admin separators, and prevents new separators from being properly rearranged. Any other plugins that do anything with menus and separators will break the same way. See screen shots for breakage.

Attached patch adds the classes back in, changes anchors to spans, and changes the cursor on separators back to normal.

Attachments (3)

Screen shot 2011-05-18 at 12.56.36 AM.png (32.5 KB) - added by johnjamesjacoby 3 years ago.
Breakage 1
Screen shot 2011-05-18 at 1.03.47 AM.png (32.8 KB) - added by johnjamesjacoby 3 years ago.
Breakage 2
17484.patch (2.8 KB) - added by johnjamesjacoby 3 years ago.
Patch that addresses original issue and works with existing plugins

Download all attachments as: .zip

Change History (5)

johnjamesjacoby3 years ago

Patch that addresses original issue and works with existing plugins

comment:1 johnjamesjacoby3 years ago

Semantically, we could also use an hr element in place of an empty span. That would save us the display: block; but cost us some padding and margin adjustments for hr's. Either way the impact is negligible.

comment:2 azaozz3 years ago

  • Owner set to azaozz
  • Resolution set to fixed
  • Status changed from new to closed

In [17950]:

Revert [17943] as it breaks plugins, props johnjamesjacoby, fixes #17484

Note: See TracTickets for help on using tickets.