WordPress.org

Make WordPress Core

Opened 3 years ago

Last modified 8 months ago

#17491 reopened defect (bug)

Make is_email() compliant with RFC2822

Reported by: arena Owned by:
Milestone: Future Release Priority: normal
Severity: minor Version: 3.1.2
Component: Mail Keywords: has-patch dev-feedback
Focuses: Cc:

Description (last modified by kawauso)

is_email('toto.@…') returns true

Attachments (2)

17491.diff (538 bytes) - added by sivel 3 years ago.
#17491.patch (5.4 KB) - added by arena 2 years ago.
new patch

Download all attachments as: .zip

Change History (21)

comment:1 arena3 years ago

toto.@… does not comply with RFC 2822

comment:2 scribu3 years ago

  • Keywords needs-patch added; dev-feedback removed
  • Milestone changed from Awaiting Review to Future Release
  • Severity changed from critical to minor
  • Summary changed from is_email('toto.@toto.com') returns true !!!! to is_email('toto.@toto.com') returns true

Let's not get carried away.

sivel3 years ago

comment:3 sivel3 years ago

  • Keywords has-patch added; needs-patch removed

Patch adds in the rest of the regex from http://www.regular-expressions.info/email.html for the local part.

comment:4 scribu3 years ago

  • Milestone changed from Future Release to 3.2

comment:5 ryan3 years ago

  • Milestone changed from 3.2 to Future Release

comment:6 arena2 years ago

  • Keywords dev-feedback added

Here is a new fix (#17491.patch) with code from the class swiftmailer

http://swiftmailer.org

to comply with RFC2822

arena2 years ago

new patch

comment:7 follow-up: arena2 years ago

  • Resolution set to duplicate
  • Status changed from new to closed

duplicate with #19759

comment:8 in reply to: ↑ 7 ; follow-up: kawauso2 years ago

Replying to arena:

duplicate with #19759

Are we closing an existing ticket with feedback and milestone in favour of a new one with a similar patch and issue or am I missing something?

comment:9 in reply to: ↑ 8 helenyhou2 years ago

  • Resolution duplicate deleted
  • Status changed from closed to reopened

Replying to kawauso:

Are we closing an existing ticket with feedback and milestone in favour of a new one with a similar patch and issue or am I missing something?

I think arena may be trying to bump the ticket. Closing #19759 as duplicate - patch is exactly the same as #17491.patch.

comment:10 arena2 years ago

my purpose was not to bump but to clarify the situation with a more specific title : making is_email() compliant with rfc2822.

comment:11 helenyhou2 years ago

  • Summary changed from is_email('toto.@toto.com') returns true to Make is_email() compliant with RFC2822

comment:12 arena2 years ago

  • Summary changed from Make is_email() compliant with RFC2822 to Make is_email() compliant with RFC2822 !

comment:13 kawauso2 years ago

  • Description modified (diff)
  • Summary changed from Make is_email() compliant with RFC2822 ! to Make is_email() compliant with RFC2822

No need, really. Especially for those of us with email threads.

comment:14 follow-up: miqrogroove17 months ago

Have you considered simply adopting the Google solution? They offer a free PHP script for e-mail syntax validation.

comment:15 in reply to: ↑ 14 arena17 months ago

Replying to miqrogroove:

Have you considered simply adopting the Google solution? They offer a free PHP script for e-mail syntax validation.

any link to check that 'magic' google code , thanks

comment:17 rmccue15 months ago

(Worth noting that's not actually a Google-written piece of code, it's just hosted on Google Code.)

comment:19 SergeyBiryukov8 months ago

  • Component changed from General to Mail

Related: #25108

Note: See TracTickets for help on using tickets.