Make WordPress Core

Opened 5 years ago

Closed 5 years ago

#17495 closed defect (bug) (fixed)

blip.tv oEmbeds don't work

Reported by: atoon Owned by: nacin
Milestone: 3.2 Priority: normal
Severity: normal Version: 3.2
Component: Media Keywords: has-patch
Focuses: Cc:


It seems that by some reason, blip.tv oEmbeds don't work. Probably related to the fact they use a different URL for videos right now. If I test it using http://blip.tv/oembed with current URL's still retrieves the correct code, but still don't work in WordPress.

Attachments (2)

17495-wp-fix.diff (1.1 KB) - added by blepoxp 5 years ago.
17495-wp-blip-fix.diff (1.5 KB) - added by blepoxp 5 years ago.

Download all attachments as: .zip

Change History (8)

#1 @nacin
5 years ago

  • Milestone changed from Awaiting Review to 3.2

Looks like 'http://blip.tv/file/*' needs to become 'http://blip.tv/* based on the new structure there.

I think they also used to leverage subdomains for shows but that seems to be gone.

#2 @blepoxp
5 years ago

  • Keywords has-patch added

nacin was correct about removing /file/ but a coworker and I also found that there was an error in the JSON returned by blip.tv.
I'm not sure if you want to introduce a workaround into core since it's their problem but I'm attaching two diffs. One resolves just the WordPress problem. The other includes a workaround the blip.tv's error.

5 years ago

#3 @nacin
5 years ago

What precisely is the blip.tv formatting error? I've emailed with them before, and they got back to me (with a fix upstream) within like 24 hours.

#4 @blepoxp
5 years ago

It looks like they're missing a comma after the author_name value:

I spoke with one of their employees on Twitter but an email would probably be good:

Version 0, edited 5 years ago by blepoxp (next)

#5 @blepoxp
5 years ago

Jake Simms from blip says it should be repaired on their end shortly so 17495-wp-fix.diff should be sufficient.

#6 @nacin
5 years ago

  • Owner set to nacin
  • Resolution set to fixed
  • Status changed from new to closed

In [17978]:

Update the blip.tv regex. props blepoxp, fixes #17495.

Note: See TracTickets for help on using tickets.