Opened 14 years ago
Closed 14 years ago
#17499 closed defect (bug) (fixed)
"Add New" quick links not present on Edit Foo admin pages
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 3.2 | Priority: | normal |
Severity: | normal | Version: | 3.2 |
Component: | Administration | Keywords: | has-patch dev-feedback |
Focuses: | Cc: |
Description (last modified by )
Attachments (3)
Change History (14)
#1
@
14 years ago
- Description modified (diff)
- Owner set to markjaquith
- Status changed from new to accepted
#4
@
14 years ago
- Resolution fixed deleted
- Status changed from closed to reopened
Should we do this elsewhere? Adding new users, links, media, etc., when editing one?
#5
@
14 years ago
- Cc sbressler@… added
- Keywords has-patch dev-feedback added
Added a patch for the other three pages, as discussed with Nacin.
Separately, I think it'd be nice to add something on the edit-tags.php?action=edit
section when editing taxonomy terms as well, perhaps "Add Tag, Category, Whatever" as the other pages will now have, but perhaps something as simple as "« Back" would suffice since adding those terms happens when editing the taxonomy itself on the page the user must have just come from.
Any other pages where any similar "fav link 2.0" treatment might make sense?
#6
@
14 years ago
Looks like the "Add New" on media.php should get a cap check of upload_files. The page that's coming from is blocked by upload_files, but media.php appears to be just blocked by edit_post (on the attachment ID). Links should be fine though, there's only one cap there. Users is already checked in the patch.
#7
@
14 years ago
Refreshed diff (small change, so just overwrote previous file) per Nacin's comment
#8
@
14 years ago
Refreshed one more time, with slight simplification to make Edit Media page more like Edit Users page.
@
14 years ago
Patch for edit user, edit link, and edit media pages (with proper cap checks). No link when editing profile page
#9
@
14 years ago
And refreshed again, this time with a link on the Edit User page if and only if it's not the current user being edited (i.e. not on profile.php). If you're editing your own profile, I don't think it makes sense or is helpful to include such a link.
Obviously the previous diff could be used if others disagree and indeed want to include the Add User link on all edit user pages, including the profile.
Fine by me.