Make WordPress Core

Opened 14 years ago

Closed 14 years ago

#17499 closed defect (bug) (fixed)

"Add New" quick links not present on Edit Foo admin pages

Reported by: markjaquith's profile markjaquith Owned by: markjaquith's profile markjaquith
Milestone: 3.2 Priority: normal
Severity: normal Version: 3.2
Component: Administration Keywords: has-patch dev-feedback
Focuses: Cc:

Description (last modified by markjaquith)

With the "Favorite Actions" of WP 3.1, the "Add New" action for the current post type was available when editing content. Now it's not, and you have to hunt in the menu for it.

We should bring back the "Add New" links in this scenario. They're super-handy.

Proposed:

http://cl.ly/27302L0r3h0L0K1q3l3w/Screen_shot_2011-05-18_at_8.17.49_PM.png

Attachments (3)

17499.diff (1.4 KB) - added by markjaquith 14 years ago.
17499.other-pages.diff (2.1 KB) - added by sbressler 14 years ago.
Patch for edit user, edit link, and edit media pages (with proper cap checks)
17499.other-pages.2.diff (2.2 KB) - added by sbressler 14 years ago.
Patch for edit user, edit link, and edit media pages (with proper cap checks). No link when editing profile page

Download all attachments as: .zip

Change History (14)

@markjaquith
14 years ago

#1 @markjaquith
14 years ago

  • Description modified (diff)
  • Owner set to markjaquith
  • Status changed from new to accepted

#2 @ryan
14 years ago

Fine by me.

#3 @markjaquith
14 years ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In [17962]:

Add New links when editing content. fixes #17499

#4 @nacin
14 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

Should we do this elsewhere? Adding new users, links, media, etc., when editing one?

#5 @sbressler
14 years ago

  • Cc sbressler@… added
  • Keywords has-patch dev-feedback added

Added a patch for the other three pages, as discussed with Nacin.

Separately, I think it'd be nice to add something on the edit-tags.php?action=edit section when editing taxonomy terms as well, perhaps "Add Tag, Category, Whatever" as the other pages will now have, but perhaps something as simple as "« Back" would suffice since adding those terms happens when editing the taxonomy itself on the page the user must have just come from.

Any other pages where any similar "fav link 2.0" treatment might make sense?

#6 @nacin
14 years ago

Looks like the "Add New" on media.php should get a cap check of upload_files. The page that's coming from is blocked by upload_files, but media.php appears to be just blocked by edit_post (on the attachment ID). Links should be fine though, there's only one cap there. Users is already checked in the patch.

#7 @sbressler
14 years ago

Refreshed diff (small change, so just overwrote previous file) per Nacin's comment

@sbressler
14 years ago

Patch for edit user, edit link, and edit media pages (with proper cap checks)

#8 @sbressler
14 years ago

Refreshed one more time, with slight simplification to make Edit Media page more like Edit Users page.

@sbressler
14 years ago

Patch for edit user, edit link, and edit media pages (with proper cap checks). No link when editing profile page

#9 @sbressler
14 years ago

And refreshed again, this time with a link on the Edit User page if and only if it's not the current user being edited (i.e. not on profile.php). If you're editing your own profile, I don't think it makes sense or is helpful to include such a link.

Obviously the previous diff could be used if others disagree and indeed want to include the Add User link on all edit user pages, including the profile.

#10 @scribu
14 years ago

Related: #17516

#11 @nacin
14 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In [17975]:

Add 'Add New' buttons to edit links, edit media, and edit user screens. props sbressler, fixes #17499.

Note: See TracTickets for help on using tickets.