WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 3 years ago

#17511 closed defect (bug) (fixed)

_access_denied_splash() doesn't account for the network admin

Reported by: kawauso Owned by: ryan
Milestone: 3.2 Priority: normal
Severity: normal Version: 3.2
Component: Administration Keywords: has-patch
Focuses: Cc:

Description

If a user with insufficient permissions attempts to access the network admin, the splash refers to it in the context of the main site, not the network.

You attempted to access the "Foo" dashboard, but you do not currently have privileges on this site. If you believe you should be able to access the "Foo" dashboard, please contact your network administrator.

It would make more sense if it was something like:

You attempted to access the network dashboard, but you do not currently have sufficient privileges on this network. If you believe you should be able to access the network dashboard, please contact your network administrator.

On a related note, isn't the dashboard meant to refer only to a specific page? The splash currently displays for any pages with insufficient permissions and those that don't exist.

Attachments (2)

17511.diff (799 bytes) - added by kawauso 3 years ago.
Add a condition for the network admin
17511.2.diff (461 bytes) - added by sorich87 3 years ago.
Return if is_network_admin so that default handler is used

Download all attachments as: .zip

Change History (6)

kawauso3 years ago

Add a condition for the network admin

comment:1 nacin3 years ago

  • Milestone changed from Awaiting Review to 3.2

comment:2 ryan3 years ago

Is that the right patch kawauso?

_access_denied_splash() could also just return if is_network_admin() and let the default handler take care of things.

sorich873 years ago

Return if is_network_admin so that default handler is used

comment:3 sorich873 years ago

With this patch, _access_denied_splash() returns if is_network_admin()

comment:4 ryan3 years ago

  • Owner set to ryan
  • Resolution set to fixed
  • Status changed from new to closed

In [18009]:

Don't show _access_denied_splash() for network admin pages. Props sorich87. fixes #17511

Note: See TracTickets for help on using tickets.