_access_denied_splash() doesn't account for the network admin

[kawauso]

If a user with insufficient permissions attempts to access the network admin, the splash refers to it in the context of the main site, not the network.

You attempted to access the "Foo" dashboard, but you do not currently have privileges on this site. If you believe you should be able to access the "Foo" dashboard, please contact your network administrator.

It would make more sense if it was something like:

You attempted to access the network dashboard, but you do not currently have sufficient privileges on this network. If you believe you should be able to access the network dashboard, please contact your network administrator.

On a related note, isn't the dashboard meant to refer only to a specific page? The splash currently displays for any pages with insufficient permissions and those that don't exist.

[kawauso]

Add a condition for the network admin

[ryan]

Is that the right patch kawauso?

_access_denied_splash() could also just return if is_network_admin() and let the default handler take care of things.

[sorich87]

Return if is_network_admin so that default handler is used

[sorich87]

With this patch, _access_denied_splash() returns if is_network_admin()

[ryan]

In [18009]:

Don't show _access_denied_splash() for network admin pages. Props sorich87. fixes #17511