WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 4 years ago

#17514 closed defect (bug) (fixed)

_access_denied_splash() wording doesn't account for insufficient permissions

Reported by: kawauso Owned by: ryan
Milestone: 3.2 Priority: normal
Severity: normal Version: 3.2
Component: General Keywords: has-patch
Focuses: Cc:

Description

The error presented when a user can't access a page either due to insufficient permissions or because it doesn't exist in 3.1 was:

You do not have sufficient permissions to access this page.

whereas in 3.2 it is now:

You attempted to access the "Foo" dashboard, but you do not currently have privileges on this site. If you believe you should be able to access the "Foo" dashboard, please contact your network administrator.

The new message implies the user doesn't have any permissions, rather than just insufficient permissions.

It only affects plugin/theme created pages, since core admin pages still use the "Cheatin’ uh?" message.

Related: #17511

Attachments (1)

17514.diff (431 bytes) - added by sorich87 4 years ago.
access_denied_splash() return if the user belongs to the current blog

Download all attachments as: .zip

Change History (5)

comment:1 @nacin4 years ago

  • Milestone changed from Awaiting Review to 3.2

comment:2 @ryan4 years ago

If the user belongs to the current blog, perhaps _access_denied_splash() should simply return and let the default handler take over.

@sorich874 years ago

access_denied_splash() return if the user belongs to the current blog

comment:3 @sorich874 years ago

  • Keywords has-patch added

comment:4 @ryan4 years ago

  • Owner set to ryan
  • Resolution set to fixed
  • Status changed from new to closed

In [18008]:

Don't show _access_denied_splash() if the user has permissions for the site but insufficient perms for a particular page. Props sorich87. fixes #17514

Note: See TracTickets for help on using tickets.