ms-blogs dynamic strings to static strings

[niallkennedy]

wp-includes/ms-blogs.php builds some option key strings with dynamic string components that should instead be static strings. Speed.

[niallkennedy]

static strings

[scribu]

When you cite speed as a reason, you'd better have some benchmarks handy.

Please don't open any more tickets of this type until you can prove that they provide a non-trivial performance boost.

[scribu]

Sorry for the rather aggressive tone, but I get annoyed when time is spent on useless optimizations.

Please provide some tests.

[niallkennedy]

single vs. double quoted string tests based on options use

[niallkennedy]

Initial patch corrects for ​WordPress Coding Standards for strings:

If you're not evaluating anything in the string, use single quotes.

Variables and escape sequences for special characters are not expanded when they occur in single-quoted ​strings. So you would think not having to look for extra things within a string declaration would process more quickly. We can run some tests and confirm the performance angle. string-test.php added to ticket. In my PHP 5.3 CLI tests the single quoted strings were faster. "Non-trivial" up for debate.

Patch is admittedly trivial compared to rewriting Media or something similar. Yet if I'm already inside a file and notice something not to Coding Standards or capable of making a few million websites run nanoseconds faster I figure why not flag the diff and improve the software.

[scribu]

A couple of things:

1) Patches that just fix coding standards are discouraged. They can invalidate other patches that actually deal with code logic, or even with inline docs, while providing a fraction of the benefit.

2) If patches are very similar, they should be uploaded to a single ticket.

Going to close all such tickets as duplicates of #16474, since that is the oldest one.

Feel free to re-upload all the patches there.

[nacin]

In [17988]:

Single quotes and spaces in ms-blogs.php. props niallkennedy, fixes #17522.