Context Navigation

← Previous Ticket
Next Ticket →

#17527 closed defect (bug) (fixed)

Select All checkbox on comment moderation page doesn't uncheck items when unchecked.

Reported by:	tmtrademark	Owned by:	azaozz
Priority:	normal	Milestone:	3.2
Component:	Administration	Version:	3.2
Severity:	major	Keywords:
Cc:		Focuses:

Description

On the users, comments and post moderation pages in wp-admin (eg, /wp-admin/edit-comments.php, users.php, edit.php) checking, then unchecking the 'select all' box does not unselect all the displayed items.

How To Reproduce:

Log in to wp-admin
Navigate to /edit.php
Check upper left hand checkbox to 'select all'
Uncheck box.
Posts (or users or comments) remain checked.

A blog running 3.1.2 does not exhibit this behavior.

Problem occurs even with twentyten and no plugins.

Chrome 13.0.767.1, OS x 10.6

Change History (7)

#1 @nacin
15 years ago

Milestone Awaiting Review → 3.2
Severity normal → major

#2 @scribu
15 years ago

Component Comments → Administration

#3 @azaozz
15 years ago

Owner set to azaozz
Resolution → fixed
Status new → closed

In [17979]:

Fix select all checkboxes JS function, another .attr() vs .prop() case in jQuery 1.6.1, fixes #17527

#4 follow-up: ↓ 5 @scribu
15 years ago

$(this).prop('checked') could just be this.checked, no?

#5 in reply to: ↑ 4 @azaozz
15 years ago

Replying to scribu:

In theory - yes, in practice I seem to remember some browsers having problems there when checkboxes are checked by JS (it could be old browsers that we no longer support though).

#6 follow-up: ↓ 7 @ocean90
15 years ago

Azaozz, in [17979] is a change related to #17523, by mistake?

#7 in reply to: ↑ 6 @azaozz
15 years ago

Replying to ocean90:

Yes, was testing it and forgot to take it out. But it fixes #17523 so may as well leave it.

Note: See TracTickets for help on using tickets.

Download in other formats:

Make WordPress Core

Context Navigation

#17527 closed defect (bug) (fixed)

Select All checkbox on comment moderation page doesn't uncheck items when unchecked.

Description

Change History (7)

#1 @nacin 15 years ago

#2 @scribu 15 years ago

#3 @azaozz 15 years ago

#4 follow-up: ↓ 5 @scribu 15 years ago

#5 in reply to: ↑ 4 @azaozz 15 years ago

#6 follow-up: ↓ 7 @ocean90 15 years ago

#7 in reply to: ↑ 6 @azaozz 15 years ago