WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#17527 closed defect (bug) (fixed)

Select All checkbox on comment moderation page doesn't uncheck items when unchecked.

Reported by: tmtrademark Owned by: azaozz
Milestone: 3.2 Priority: normal
Severity: major Version: 3.2
Component: Administration Keywords:
Focuses: Cc:

Description

On the users, comments and post moderation pages in wp-admin (eg, /wp-admin/edit-comments.php, users.php, edit.php) checking, then unchecking the 'select all' box does not unselect all the displayed items.

How To Reproduce:

  1. Log in to wp-admin
  2. Navigate to /edit.php
  3. Check upper left hand checkbox to 'select all'
  4. Uncheck box.
  5. Posts (or users or comments) remain checked.

A blog running 3.1.2 does not exhibit this behavior.

Problem occurs even with twentyten and no plugins.

Chrome 13.0.767.1, OS x 10.6

Change History (7)

comment:1 nacin3 years ago

  • Milestone changed from Awaiting Review to 3.2
  • Severity changed from normal to major

comment:2 scribu3 years ago

  • Component changed from Comments to Administration

comment:3 azaozz3 years ago

  • Owner set to azaozz
  • Resolution set to fixed
  • Status changed from new to closed

In [17979]:

Fix select all checkboxes JS function, another .attr() vs .prop() case in jQuery 1.6.1, fixes #17527

comment:4 follow-up: scribu3 years ago

$(this).prop('checked') could just be this.checked, no?

comment:5 in reply to: ↑ 4 azaozz3 years ago

Replying to scribu:

In theory - yes, in practice I seem to remember some browsers having problems there when checkboxes are checked by JS (it could be old browsers that we no longer support though).

comment:6 follow-up: ocean903 years ago

Azaozz, in [17979] is a change related to #17523, by mistake?

comment:7 in reply to: ↑ 6 azaozz3 years ago

Replying to ocean90:

Yes, was testing it and forgot to take it out. But it fixes #17523 so may as well leave it.

Note: See TracTickets for help on using tickets.