Credits screen: show translators, untranslatable string, generic function name

[dimadin]

• Since locale is already passed to request, translators can be shown in credits too. GlotPress can return list of validators for that locale. One installation can have more than one locale so transients should be based on locale.
• String "Core Contributors to WordPress %s" is untranslatable since version is returned in response, instead placeholder must be returned.
• Function add_css() has generic name so I think that it should be prefixed.

[nacin]

We use add_css() in a number of other situations in core without issue. If a plugin defined that function, lots of things would break.

[nacin]

Placeholders are now returned in the response.

[nacin]

Hm, it's actually add_js() that gets used elsewhere.

[nacin]

In [17980]:

s/add_css/_wp_credits_add_css/. props dimadin, see #17532.

[nacin]

We had been planning to add new groups including translators. I'll talk with Jane to see how scalable the API should become before implementing anything else.

[nacin]

In [18001]:

Update the Credits page for changes in the API. see #17532.

[nacin]

In [18002]:

Prepare the Credits page to handle translators. see #17532.

[nacin]

In [18004]:

Add paragraph tags around the blocks of contributors. see #17532.

[westi]

In [18005]:

Use context to tell the translators what to do and thereby remove a unused string.
Add a comment as to why we have translations after a return.
See #17532

[nacin]

In [18007]:

String swap. see #17532.

[nacin]

In [18162]:

Credits screen redux. Add external libraries, gravatars for language validators. Backed by a new API. fixes #17518, fixes #17532.

[scribu]

The translators that don't have gravatars have incorrect links:

​http://profiles.wordpress.org/users/0 ​http://profiles.wordpress.org/users/1

etc.

[westi]

Replying to scribu:

The translators that don't have gravatars have incorrect links:

​http://profiles.wordpress.org/users/0 ​http://profiles.wordpress.org/users/1

etc.

It would be better to open new tickets for issues so that they don't get lost.

[nacin]

Cannot reproduce using the latest response from the API. Please flush the transient if you're having trouble.

Closing as fixed. Re-open a new ticket with steps to reproduce (please provide the localization you're using -- ro_RO works for me) if you can.

[nacin]

My bad, I hadn't committed and deployed a fix. All set now.

[scribu]

Thanks, works now.

It would be better to open new tickets for issues so that they don't get lost.

It was a bug in the implementation of the current feature and I'm pretty sure it wouldn't get lost, since I re-opened the ticket.

[scribu]

Though I admit a re-opened ticket looks worse in the timeline than a new one.