WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 3 weeks ago

#17545 closed defect (bug) (fixed)

Pagination Broken on Network Admin > Edit Site > Themes

Reported by: pmaiorana Owned by: nacin
Milestone: 3.9 Priority: normal
Severity: normal Version: 3.2
Component: Themes Keywords: has-patch
Focuses: administration, multisite Cc:

Description

Pagination is broken in network admin on pages such as https://example.com/wp-admin/network/site-themes.php?id=XXXXX

You can navigate through pages using the arrow buttons, but entering a page number just reloads the page you’re currently on.

Steps to reproduce:

  • From network admin, "search sites"
  • Edit site
  • Click "themes" tab
  • Enter any valid page number in the text field
  • Hit enter

Attachments (4)

17545.diff (1.6 KB) - added by kawauso 3 years ago.
17545.2.diff (1.1 KB) - added by kawauso 22 months ago.
Refreshed against r21186
17545.3.diff (1.1 KB) - added by jeremyfelt 3 months ago.
17545.4.diff (1.2 KB) - added by jeremyfelt 3 months ago.
Add braces for new coding standards

Download all attachments as: .zip

Change History (15)

comment:1 westi3 years ago

  • Keywords needs-patch added
  • Version set to 3.2

comment:2 kawauso3 years ago

Also affects site-users.php. Following patch adds request URI clean-up from site-themes.php to site-users.php and paged query variable support for both.

comment:3 kawauso3 years ago

  • Keywords has-patch added; needs-patch removed

kawauso3 years ago

comment:4 SergeyBiryukov3 years ago

  • Milestone changed from Awaiting Review to 3.3

comment:5 jane3 years ago

Pinging Pete Mall.

comment:6 PeteMall3 years ago

On it for tonight.

comment:7 ryan2 years ago

  • Milestone changed from 3.3 to Future Release

kawauso22 months ago

Refreshed against r21186

comment:8 nacin3 months ago

  • Component changed from Network Admin to Themes
  • Focuses administration added

comment:9 ircbot3 months ago

This ticket was mentioned in IRC in #wordpress-dev by nacin. View the logs.

jeremyfelt3 months ago

jeremyfelt3 months ago

Add braces for new coding standards

comment:10 jeremyfelt3 months ago

  • Milestone changed from Future Release to 3.9

17545.4.diff is a refresh of @kawauso's patch against trunk.

This fixes the issue where entering a page number directly in the top right of the list tables for site-users.php and site-themes.php causes the page to reload. Things work in my testing.

comment:11 nacin3 weeks ago

  • Owner set to nacin
  • Resolution set to fixed
  • Status changed from new to closed

In 27715:

Network Admin: Fix pagination on site-themes and site-users.

props kawauso, jeremyfelt.
fixes #17545.

Note: See TracTickets for help on using tickets.