WordPress.org

Make WordPress Core

Opened 11 years ago

Closed 11 years ago

Last modified 11 years ago

#17563 closed defect (bug) (fixed)

Twenty Eleven esc_url() throughout

Reported by: mfields Owned by: iandstewart
Milestone: 3.2 Priority: normal
Severity: normal Version:
Component: Bundled Theme Keywords: needs-refresh
Focuses: Cc:

Description

Better escaping of urls in Twenty Eleven.

Attachments (1)

17563.url-escaping-in-twenty-eleven.diff (15.1 KB) - added by mfields 11 years ago.

Download all attachments as: .zip

Change History (15)

#1 @nacin
11 years ago

  • Milestone changed from Awaiting Review to 3.2

#2 @iandstewart
11 years ago

This patch could probably be combined with the improvements in #17385

#3 @mfields
11 years ago

I combined the appropriate changes and uploaded a new patch for #17385.

#4 @mfields
11 years ago

  • Keywords needs-refresh added; has-patch dev-feedback removed

I will do another pass it this once #17385 is committed.

#5 @westi
11 years ago

  • Owner set to iandstewart
  • Status changed from new to assigned

#6 @westi
11 years ago

  • Component changed from Themes to Bundled Theme

#7 @iandstewart
11 years ago

  • Resolution set to duplicate
  • Status changed from assigned to closed

Marking this ticket as a duplicate as an updated patch has been added to #17385

#8 follow-up: @mfields
11 years ago

There are definitely areas in this ticket that have not been added in the #17385.

#9 @iandstewart
11 years ago

  • Resolution duplicate deleted
  • Status changed from closed to reopened

#10 in reply to: ↑ 8 @iandstewart
11 years ago

There are definitely areas in this ticket that have not been added in the #17385.

Is there a refreshed patch on the way?

#11 @mfields
11 years ago

Yeah, I will make one in the next couple of hours. I'm still getting comfortable with svn and my first attempt at doing this was a bit wonky. I'll go through it line-by-line in a little bit.

#12 @mikeschroder
11 years ago

Added combination of Newest patches from here and #17385, with additional esc_url as appropriate, to #17385

#13 @iandstewart
11 years ago

  • Resolution set to duplicate
  • Status changed from reopened to closed

With DH-Shredder's patch this looks like a duplicate now.

#14 @nacin
11 years ago

  • Resolution changed from duplicate to fixed

In [18244]:

Twenty Eleven: escaping frenzy, hide authors if a single author blog. props DH-Shredder, props iandstewart, see #17385, fixes #17563.

Note: See TracTickets for help on using tickets.