wp_list_pages() not setting "current_page_item" classes on custom post types

[tobiasn]

wp_list_pages() don't set the correct css for a hierarchical custom post type.

To reproduce this bug do this:
<?php wp_list_pages("title_li=&post_type=custom_post_type_name"); ?>

and compare the html output to normal pages:
<?php wp_list_pages(); ?>

The problem seems to be this row in wp_list_pages():

if ( is_page() || is_attachment() || $wp_query->is_posts_page )

In the following patch i've changed it to

if ( is_page() || is_attachment() || $wp_query->is_posts_page || ($wp_query->query_vars['post_type'] != 'post' && is_single()) )

(If this is not the intended behavoir please let me know. )

[tobiasn]

wp_list_pages() css patch for custom post types

[husobj]

As a temporary measure you can hook into to add selected classes like this:

function my_page_css_class( $css_class, $page ) {
	global $post;
	if ( $post->ID == $page->ID ) {
		$css_class[] = 'current_page_item';
	}
	return $css_class;
}
add_filter( 'page_css_class', 'my_page_css_class', 10, 2 );

[SergeyBiryukov]

Corrected markup.

[tobiasn]

Nice quickfix, however i would prefer pinpointing custom post types.

Replying to husobj:

As a temporary measure you can hook into to add selected classes like this:

function my_page_css_class( $css_class, $page ) {
	global $post;
	if ( $post->ID == $page->ID ) {
		$css_class[] = 'current_page_item';
	}
	return $css_class;
}
add_filter( 'page_css_class', 'my_page_css_class', 10, 2 );

[depi]

Thanks for the fix with the hook guys.
However I really wonder why it is still not fixed after 9 months.

[daveleeone]

Thanks for the very useful hook, but how can I highlight the parent page? At the moment I use Jquery for this.

Any Ideas?

Thanks, Davelee

[tobiasn]

Hi dave! I haven't noticed the parent page-thing, guess that's a bug in the Walker class. How do I recreate it?

[daveleeone]

Hi Tobias, thanks for reply.
I have not seen, unfortunately, you've written back to me.

here is my code in the template:

function file:

function my_page_css_class( $css_class, $page ) {
	global $post;
	if ( $post->ID == $page->ID ) {
		$css_class[] = 'current_page_item';
	}
	return $css_class;
}
add_filter( 'page_css_class', 'my_page_css_class', 10, 2 );

template file:

<?php
// create a ID of parent page to use the wp_list_page as submenu
			if ($post->post_parent)	{
				$ancestors=get_post_ancestors($post->ID);
				$root=count($ancestors)-1;
				$parent = $ancestors[$root];
			} else {
				$parent = $post->ID;
			}

?>	

<ul class="submenu">
<?php 
// create a Submenu for CPT's 

	$args = array(
	'post_type'	=>	'event',
	'child_of'	=>	$parent,
	'title_li'	=>	__('')
);
wp_list_pages( $args ); 
?> 
</ul>

jquery file

 $(document).ready(function(){
	$('.submenu li:has(li.current_page_item)').addClass('parent_page_item');	

});

I hope it helps.
if you make it I'll pay you a beer :)

[tobiasn]

Hi Dave! This has nothing to do with the trac bug. Could you please remove the comment here and repost it in the support forum? I'll answer you there.

[thomas.mery]

Hi,

I was wondering if this had been looked at ?

it seems like this would be quite useful now that CPT are used so often by the wp community

thanks

[SergeyBiryukov]

Closed #21525 as a duplicate.

[SergeyBiryukov]

17590.2.patch​ does a hierarchical check, as suggested during the ​bug scrub.

is_attachment() was added in [10947] (for #9472), so I've kept it.

[nacin]

get('post_type') could be an array.

[Clorith]

Updated .patch to reflect recent changes to post-template.php

[obenland]

Updated patch based on SergeyBiryukov's initial pass.

[billerickson]

Patch looks good to me. Anything I can do to help this get in core? Just ran into this issue myself.

[tobiasn]

I think @obenland patch works perfect and addresses the @nacin issue but I don't really know how to get this fix into 3.9. Any suggestions? :)

Replying to billerickson:

Patch looks good to me. Anything I can do to help this get in core? Just ran into this issue myself.

[nacin]

Looks good. The is_singular() should ensure this is checking a single post type.

[nacin]

17590.diff​ is a slightly more defensive approach. get_post_type() simply returns the post type query variable, which could very well have been changed to an array on pre_get_posts even after is_singular was set in parse_query(). Instead, we can use the queried object, which isn't foolproof either but is at least it's consistent for what we're doing here.

[wonderboymusic]

In 27755:

In wp_list_pages(), add the current_page_item class where applicable when used with a custom post type.

Adds a unit test.

Props nacin.
Fixes #17590.