WordPress.org
Get WordPress

Make WordPress Core

Opened 15 years ago

Closed 15 years ago

Last modified 15 years ago

#17602 closed enhancement (fixed)

credits page - li.wp-person - float right (Arabic RTL)

Reported by: rasheed Owned by: nacin
Priority: normal Milestone: 3.2
Component: RTL Version: 3.2
Severity: normal Keywords:
Cc: Focuses:

Description

Hello,

Please check the attached snapshot.

link:
../wordpress/3-2-beta-2/wp-admin/credits.php

li.wp-person {

float: left;
height: 100px;
margin-right: 20px;
width: 240px;

}

float should be right.

Attachments (4)

wp-person.jpg​ (142.5 KB ) - added by rasheed 15 years ago.
17602.diff​ (843 bytes ) - added by BenChapman 15 years ago.
Added an if(is_rtl()) into wp-admin/credits.php which makes li.wp-person float right if page is RTL
17602.2.diff​ (964 bytes ) - added by ryan 15 years ago.
untitled.PNG​ (179.1 KB ) - added by ramiy 15 years ago.

Download all attachments as: .zip

Change History (10)

@rasheed
15 years ago

#1 @nacin
15 years ago

  • Milestone Awaiting Review → 3.2
  • Owner set to nacin
  • Status new → accepted

@BenChapman
15 years ago

Added an if(is_rtl()) into wp-admin/credits.php which makes li.wp-person float right if page is RTL

#2 @BenChapman
15 years ago

  • Cc admin@… added

@ryan
15 years ago

#3 @ryan
15 years ago

  • Resolution → fixed
  • Status accepted → closed

In [18116]:

RTL fixes for credits.php. Props BenChapman, rasheed. fixes #17602

#4 @ramiy
15 years ago

  • Resolution fixed
  • Status closed → reopened

more RTL fixes needed. see attached screenshot (Hebrew RTL).

@ramiy
15 years ago

#5 @ryan
15 years ago

  • Resolution → fixed
  • Status reopened → closed

In [18149]:

RTL fixes for credits.php. fixes #17602

#6 @SergeyBiryukov
15 years ago

  • Keywords rtl-feedback removed
Note: See TracTickets for help on using tickets.