WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#17602 closed enhancement (fixed)

credits page - li.wp-person - float right (Arabic RTL)

Reported by: rasheed Owned by: nacin
Milestone: 3.2 Priority: normal
Severity: normal Version: 3.2
Component: RTL Keywords:
Focuses: Cc:

Description

Hello,

Please check the attached snapshot.

link:
../wordpress/3-2-beta-2/wp-admin/credits.php

li.wp-person {

float: left;
height: 100px;
margin-right: 20px;
width: 240px;

}

float should be right.

Attachments (4)

wp-person.jpg (142.5 KB) - added by rasheed 3 years ago.
17602.diff (843 bytes) - added by BenChapman 3 years ago.
Added an if(is_rtl()) into wp-admin/credits.php which makes li.wp-person float right if page is RTL
17602.2.diff (964 bytes) - added by ryan 3 years ago.
untitled.PNG (179.1 KB) - added by ramiy 3 years ago.

Download all attachments as: .zip

Change History (10)

rasheed3 years ago

comment:1 nacin3 years ago

  • Milestone changed from Awaiting Review to 3.2
  • Owner set to nacin
  • Status changed from new to accepted

BenChapman3 years ago

Added an if(is_rtl()) into wp-admin/credits.php which makes li.wp-person float right if page is RTL

comment:2 BenChapman3 years ago

  • Cc admin@… added

ryan3 years ago

comment:3 ryan3 years ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In [18116]:

RTL fixes for credits.php. Props BenChapman, rasheed. fixes #17602

comment:4 ramiy3 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

more RTL fixes needed. see attached screenshot (Hebrew RTL).

ramiy3 years ago

comment:5 ryan3 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In [18149]:

RTL fixes for credits.php. fixes #17602

comment:6 SergeyBiryukov3 years ago

  • Keywords rtl-feedback removed
Note: See TracTickets for help on using tickets.