Inaccurate string in custom-header.php

[rasheed]

Hello,

Please check this string:
​http://translate.wordpress.org/projects/wp/dev/ar/default?filters[status]=either&filters[original_id]=8092&filters[translation_id]=729698

I think it should be:

This will restore the original header text color. You will not be able to restore any customizations.

instead of:

This will restore the original header text. You will not be able to restore any customizations.

[ocean90]

It's not only the color. Also if the text should be displayed or not.

[scribu]

Could someone point me to a tutorial that displays the header text UI?

I wasn't able to reach step 2 of the process that displays the string. Maybe it's dead code?

[ocean90]

Why step 2?

if ( defined('HEADER_TEXTCOLOR') && get_theme_mod('header_textcolor') )

=> ​http://awesomescreenshot.com/05bdv9zdc

[scribu]

Ah, I was using Twentyten.

I think rasheed is right. The button is about resetting the text color.

For displaying the text, there's the "Display Text" radio buttons above.

[scribu]

Corrected both the label and button strings.

Sidenote: That entire screen has way too much text on it.

[ocean90]

For displaying the text, there's the "Display Text" radio buttons above.

Yesno. If HEADER_TEXTCOLOR is blank then the header text is disabled. Also without JS you can't use the radio buttons.

[scribu]

The point is that clicking the "Restore Original Header Text Color" button (that's a mouth-full) won't and shouldn't affect wether the text is displayed or not.

[rasheed]

The problem there is no meaning matching between the title (Reset Text Color) and it's description (This will restore the original header text).

[ocean90]

The point is, that the button text is Restore Original Header Text and because of the function behind the button the inaccurate string is Reset Text Color, it should be simply Reset Text.

[scribu]

To clarify: "what does this button do?" (seriously)

[ocean90]

I agree, it's a little bit unclear. Primary it removes the theme mod header_textcolor. So yes it's the color. BUT when HEADER_TEXTCOLOR is empty or has the value blank the "header text color will be transparent", means the header text won't be shown. Also the radio button will switch to No.

[westi]

The wording of a number of the bits of the custom header page is akward and I want to revisit them all in one go.

Moving from 3.2 and will re-consider in 3.3

[jkudish]

updating keywords

[SergeyBiryukov]

As per westi's comment above, this needs additional work.

[chipbennett]

Related: #18887

[SergeyBiryukov]

Related: #22461

[SergeyBiryukov]

[22695] removed the button.