WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 3 years ago

#17605 closed defect (bug) (fixed)

Inaccurate string in custom-header.php

Reported by: rasheed Owned by: westi
Milestone: 3.5 Priority: normal
Severity: normal Version: 3.1
Component: Customize Keywords: dev-feedback 3.3-early
Focuses: Cc:

Description

Hello,

Please check this string:
http://translate.wordpress.org/projects/wp/dev/ar/default?filters[status]=either&filters[original_id]=8092&filters[translation_id]=729698

I think it should be:

This will restore the original header text color. You will not be able to restore any customizations.

instead of:

This will restore the original header text. You will not be able to restore any customizations.

Attachments (2)

17605.diff (771 bytes) - added by scribu 5 years ago.
17605.2.patch (650 bytes) - added by ocean90 5 years ago.

Download all attachments as: .zip

Change History (19)

#1 @ocean90
5 years ago

  • Keywords close added

It's not only the color. Also if the text should be displayed or not.

#2 @scribu
5 years ago

  • Keywords dev-feedback added; close removed

Could someone point me to a tutorial that displays the header text UI?

I wasn't able to reach step 2 of the process that displays the string. Maybe it's dead code?

Last edited 5 years ago by scribu (previous) (diff)

#3 @ocean90
5 years ago

  • Keywords dev-feedback removed

Why step 2?

if ( defined('HEADER_TEXTCOLOR') && get_theme_mod('header_textcolor') )

=> http://awesomescreenshot.com/05bdv9zdc

#4 @scribu
5 years ago

  • Component changed from General to Administration
  • Keywords needs-patch added
  • Milestone changed from Awaiting Review to Future Release
  • Type changed from enhancement to defect (bug)

Ah, I was using Twentyten.

I think rasheed is right. The button is about resetting the text color.

For displaying the text, there's the "Display Text" radio buttons above.

@scribu
5 years ago

#5 @scribu
5 years ago

  • Keywords has-patch added; needs-patch removed
  • Milestone changed from Future Release to 3.2
  • Summary changed from inaccurate string to Inaccurate string in custom-header.php

Corrected both the label and button strings.

Sidenote: That entire screen has way too much text on it.

#6 @ocean90
5 years ago

For displaying the text, there's the "Display Text" radio buttons above.

Yesno. If HEADER_TEXTCOLOR is blank then the header text is disabled. Also without JS you can't use the radio buttons.

#7 @scribu
5 years ago

The point is that clicking the "Restore Original Header Text Color" button (that's a mouth-full) won't and shouldn't affect wether the text is displayed or not.

#8 @rasheed
5 years ago

The problem there is no meaning matching between the title (Reset Text Color) and it's description (This will restore the original header text).

@ocean90
5 years ago

#9 @ocean90
5 years ago

  • Keywords dev-feedback added

The point is, that the button text is Restore Original Header Text and because of the function behind the button the inaccurate string is Reset Text Color, it should be simply Reset Text.

#10 @scribu
5 years ago

To clarify: "what does this button do?" (seriously)

#11 @ocean90
5 years ago

I agree, it's a little bit unclear. Primary it removes the theme mod header_textcolor. So yes it's the color. BUT when HEADER_TEXTCOLOR is empty or has the value blank the "header text color will be transparent", means the header text won't be shown. Also the radio button will switch to No.

#12 @westi
5 years ago

  • Keywords needs-patch 3.3-early added; has-patch removed
  • Milestone changed from 3.2 to Future Release
  • Owner set to westi
  • Status changed from new to assigned
  • Version set to 3.1

The wording of a number of the bits of the custom header page is akward and I want to revisit them all in one go.

Moving from 3.2 and will re-consider in 3.3

#13 @jkudish
5 years ago

  • Keywords has-patch added; needs-patch removed

updating keywords

#14 @SergeyBiryukov
4 years ago

  • Keywords needs-patch added; has-patch removed

As per westi's comment above, this needs additional work.

#15 @chipbennett
4 years ago

  • Cc chip@… added

Related: #18887

#17 @SergeyBiryukov
3 years ago

  • Component changed from Administration to Appearance
  • Keywords needs-patch removed
  • Milestone changed from Future Release to 3.5
  • Resolution set to fixed
  • Status changed from assigned to closed

[22695] removed the button.

Note: See TracTickets for help on using tickets.