WordPress.org

Make WordPress Core

Opened 3 years ago

Last modified 3 years ago

#17619 new enhancement

Soft 404 at /wp-content/plugins/

Reported by: miqrogroove Owned by:
Milestone: Awaiting Review Priority: normal
Severity: minor Version:
Component: General Keywords: has-patch
Focuses: Cc:

Description

/wp-content/plugins/index.php would be better written with a proper 404.

<?php
header('HTTP/1.0 404 Not Found'); // Silence is golden.
?>

Attachments (3)

17619.diff (341 bytes) - added by BenChapman 3 years ago.
Adds a 404 error message
17619.patch (664 bytes) - added by jakub.tyrcha 3 years ago.
17619.2.patch (1005 bytes) - added by jakub.tyrcha 3 years ago.

Download all attachments as: .zip

Change History (12)

comment:1 johnbillion3 years ago

Shouldn't it technically be a 403?

comment:2 miqrogroove3 years ago

Technically, there is nothing in the response entity, so either 403 or 404 is appropriate.

comment:3 toscho3 years ago

  • Cc info@… added

Why not 410? Nobody should come back, no?

comment:4 BenChapman3 years ago

As per RFC2616 if a reason is to be given for denying access then 403 should be used, otherwise 404 should be used. In this case I would say 403 would be the better response code with a reason included for forbidding access.

Version 0, edited 3 years ago by BenChapman (next)

BenChapman3 years ago

Adds a 404 error message

comment:5 BenChapman3 years ago

  • Cc admin@… added

comment:6 solarissmoke3 years ago

If this is going to change, then it should change for all wp-content directories, i.e., /themes and /uploads also.

comment:7 DH-Shredder3 years ago

  • Type changed from defect (bug) to enhancement

jakub.tyrcha3 years ago

comment:8 jakub.tyrcha3 years ago

Why should we include this in the uploads/ directory as well?

jakub.tyrcha3 years ago

comment:9 edwardw3 years ago

  • Keywords has-patch added

I feel that a 403 would be a more appropriate response since there is actually a directory, just not that one permit access to access it.

Last edited 3 years ago by edwardw (previous) (diff)
Note: See TracTickets for help on using tickets.