WordPress.org

Make WordPress Core

Opened 5 years ago

Last modified 5 months ago

#17619 new enhancement

Soft 404 at /wp-content/plugins/

Reported by: miqrogroove Owned by:
Milestone: Awaiting Review Priority: normal
Severity: normal Version:
Component: General Keywords: has-patch
Focuses: Cc:

Description

/wp-content/plugins/index.php would be better written with a proper 404.

<?php
header('HTTP/1.0 404 Not Found'); // Silence is golden.
?>

Attachments (3)

17619.diff (341 bytes) - added by BenChapman 5 years ago.
Adds a 404 error message
17619.patch (664 bytes) - added by jakub.tyrcha 5 years ago.
17619.2.patch (1005 bytes) - added by jakub.tyrcha 5 years ago.

Download all attachments as: .zip

Change History (17)

#1 @johnbillion
5 years ago

Shouldn't it technically be a 403?

#2 @miqrogroove
5 years ago

Technically, there is nothing in the response entity, so either 403 or 404 is appropriate.

#3 @toscho
5 years ago

  • Cc info@… added

Why not 410? Nobody should come back, no?

#4 @BenChapman
5 years ago

As per RFC2616 if a reason is to be given for denying access then 403 should be used, otherwise 404 should be used. In this case I would say 403 would be the better response code with a reason included for forbidding access.

Last edited 5 years ago by BenChapman (previous) (diff)

@BenChapman
5 years ago

Adds a 404 error message

#5 @BenChapman
5 years ago

  • Cc admin@… added

#6 @solarissmoke
5 years ago

If this is going to change, then it should change for all wp-content directories, i.e., /themes and /uploads also.

#7 @mikeschroder
5 years ago

  • Type changed from defect (bug) to enhancement

@jakub.tyrcha
5 years ago

#8 @jakub.tyrcha
5 years ago

Why should we include this in the uploads/ directory as well?

#9 @edwardw
5 years ago

  • Keywords has-patch added

I feel that a 403 would be a more appropriate response since there is actually a directory, just not that one permit access to access it.

Last edited 5 years ago by edwardw (previous) (diff)

#10 @chriscct7
20 months ago

  • Keywords dev-feedback added
  • Severity changed from minor to normal

#11 @DrewAPicture
20 months ago

@nacin: Possible to get a yea or nay here?

#12 @chriscct7
6 months ago

  • Keywords needs-nacin added

#13 @dd32
5 months ago

  • 404 = Technically wrong, it's not a missing resource, the resource is deliberately empty
  • 403 = Slightly more appropriate, has precedent in [30356]
  • 200 = Entirely valid IMHO, It's just an empty response to prevent directory listings.

If a committer feels strong enough for a 403, go for it.

#14 @swissspidy
5 months ago

  • Keywords dev-feedback needs-nacin removed
Note: See TracTickets for help on using tickets.