Make WordPress Core

Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#17629 closed defect (bug) (fixed)

Separator between Settings menu and top-level plugin menus needs styling

Reported by: ryan Owned by: ryan
Milestone: 3.2 Priority: normal
Severity: normal Version: 3.2
Component: Menus Keywords:
Focuses: Cc:


wp-menu-separator-last is output after the Settings menu and before any top-leve menus added to the end. wp-menu-separator-last does not match the stying of wp-menu-separator. Perhaps wp-menu-separator-last should be changed to wp-menu-separator and output only when plugins append top-level menus.

Attachments (1)

17629.diff (1.1 KB) - added by ryan 4 years ago.

Download all attachments as: .zip

Change History (4)

#1 @azaozz
4 years ago

Agree. I think wp-menu-separator-last was needed before to be able to style the menu properly but is not needed with the new styles.

4 years ago

#2 @ryan
4 years ago

  • Owner set to ryan
  • Resolution set to fixed
  • Status changed from new to closed

In [18089]:

Use wp-menu-separator after Settings and before the first plugin top-level. Remove trailing separators. fixes #17629

#3 @ryan
4 years ago

In [18109]:

Use array_pop( array_keys() ) instead of end() to find the end of the array. end() finds that last item added, which is not reliable with plugins that add items to the end and then sort them up with custom_menu_order. see #17629

Note: See TracTickets for help on using tickets.