Separator between Settings menu and top-level plugin menus needs styling

[ryan]

wp-menu-separator-last is output after the Settings menu and before any top-leve menus added to the end. wp-menu-separator-last does not match the stying of wp-menu-separator. Perhaps wp-menu-separator-last should be changed to wp-menu-separator and output only when plugins append top-level menus.

[azaozz]

Agree. I think wp-menu-separator-last was needed before to be able to style the menu properly but is not needed with the new styles.

[ryan]

In [18089]:

Use wp-menu-separator after Settings and before the first plugin top-level. Remove trailing separators. fixes #17629

[ryan]

In [18109]:

Use array_pop( array_keys() ) instead of end() to find the end of the array. end() finds that last item added, which is not reliable with plugins that add items to the end and then sort them up with custom_menu_order. see #17629