WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#17634 closed defect (bug) (fixed)

Search subtitles in admin need padding when no actions displayed

Reported by: kawauso Owned by: koopersmith
Milestone: 3.2 Priority: normal
Severity: normal Version: 3.2
Component: Administration Keywords: has-patch
Focuses: Cc:

Description

Steps to Reproduce:

  1. Load admin page where 'Add New' button is present
  2. Search for something
  3. Repeat with admin page where 'Add New' is not present i.e. Comments

Attachments (2)

17634.diff (381 bytes) - added by kawauso 3 years ago.
margin-left: 10px; no RTL
17634.2.diff (792 bytes) - added by kawauso 3 years ago.
Padding 25px (taken from 3.1) with RTL

Download all attachments as: .zip

Change History (9)

kawauso3 years ago

margin-left: 10px; no RTL

comment:1 ocean903 years ago

  • Milestone changed from Awaiting Review to 3.2

In Multisite on Users and Themes screen is something missing too: http://grab.by/agc3

kawauso3 years ago

Padding 25px (taken from 3.1) with RTL

comment:2 kawauso3 years ago

Copied styling across from 3.1. It was in wp-admin.css in 3.1, but global.css in 3.2.

comment:3 nacin3 years ago

  • Owner set to koopersmith
  • Status changed from new to assigned

Padding is fine.

Other issue is the text color. No way it's high contrast in such a narrow font. Text should probably just be black.

comment:4 ryan3 years ago

During bug scrub 10px was brought up as a good padding. koopersmith will look at this and the visibility of search string font.

comment:5 koopersmith3 years ago

  • Status changed from assigned to accepted

comment:6 ryan3 years ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In [18199]:

Add padding to search subtitle. Props kawauso. fixes #17634

comment:7 koopersmith3 years ago

In [18221]:

Darken h2 subtitles on post pages to improve readability. see #17634.

Note: See TracTickets for help on using tickets.