WordPress.org

Make WordPress Core

Opened 10 years ago

Last modified 3 weeks ago

#17636 assigned defect (bug)

Search subtitles are handled inconsistently across admin

Reported by: kawauso Owned by: chriscct7
Milestone: 5.9 Priority: normal
Severity: normal Version: 3.2
Component: Administration Keywords: has-patch
Focuses: Cc:

Description

Try the following strings in the Comments admin screen and any other:

\'"\fs"\\\"

imareallylongstringlookatmegoandgoandgoandgoandgoandgoandgoandgoandgoandgoandgoandgoandgoandgo

The Comments screen uses strip_slashes() and wp_html_excerpt() to limit search strings to 50 characters, while other screens do not.

Attachments (4)

17636.patch (670 bytes) - added by jakub.tyrcha 10 years ago.
17636.2.diff (536 bytes) - added by lukecavanagh 5 years ago.
Patch Refreshed
17636.3.diff (550 bytes) - added by sabernhardt 2 months ago.
refreshed patch
17636.png (89.1 KB) - added by Hareesh Pillai 3 weeks ago.

Download all attachments as: .zip

Change History (11)

@jakub.tyrcha
10 years ago

#1 @jakub.tyrcha
10 years ago

  • Keywords has-patch added

All we need is wp_strip_all_tags (well I'm not sure if we need even this one, but the excerpt is certainly not needed). Besides, only the display is stripped - not the search string itself (tested).

Last edited 10 years ago by jakub.tyrcha (previous) (diff)

#2 @chriscct7
7 years ago

  • Keywords needs-refresh added; has-patch removed

#3 @chriscct7
6 years ago

  • Owner set to chriscct7
  • Status changed from new to assigned

@lukecavanagh
5 years ago

Patch Refreshed

#4 @lukecavanagh
5 years ago

  • Keywords has-patch added; needs-refresh removed

@sabernhardt
2 months ago

refreshed patch

#5 @sabernhardt
2 months ago

  • Milestone set to 5.9

I don't mind the truncation, but it makes little sense to have it only on the Comments screen. So the patch is refreshed, and I'm moving it to 5.9 consideration.

The search text wraps to the next line even when it is one long word, too.

#6 @sabernhardt
2 months ago

wp_html_excerpt was added in [10082]

@Hareesh Pillai
3 weeks ago

#7 @Hareesh Pillai
3 weeks ago

Attached patch works fine.

Note: See TracTickets for help on using tickets.