Opened 14 years ago
Closed 13 years ago
#17655 closed defect (bug) (invalid)
Fix deprecated v1.2 pattern in comments_popup_link()
Reported by: |
|
Owned by: | |
---|---|---|---|
Milestone: | Priority: | normal | |
Severity: | normal | Version: | 2.0 |
Component: | General | Keywords: | has-patch |
Focuses: | Cc: |
Description
In v2.0, someone added a ridiculous if block in comments_popup_link() that duplicated the logic already contained in get_comments_link().
The patch is simple.
Attachments (1)
Change History (3)
Note: See
TracTickets for help on using
tickets.
With comments, comments_link()/get_comments_link() would correctly provide permalink#comments. However, with no comments, comments_popup_link() links to #respond.
It's silly and should have been standardized on introduction, but I'm gonna have to close this.
One of these days we will kill off comments_popup_link() for being a pain, especially when it comes to internationalization.