get_adjacent_post() uses ' and ' as undocumented separator for excluded categories

[kawauso]

get_adjacent_post() (and all derivative functions) use a non-standard and undocumented separator for IDs passed for $excluded_categories and have no support for either commas or an array.

[nacin]

That's one of the weirder things I've seen. Let's fix this.

[westi]

Replying to nacin:

That's one of the weirder things I've seen. Let's fix this.

[1557] seems to be the source.

Therefore this is not a 3.2 issue.

[solarissmoke]

Patch changes $excluded_categories to a comma-separated list, consistent with get_boundary_post(), get_posts() and related functions. Also makes this clear in the inline docs.

[nacin]

I would not mind seeing this for 3.2 anyway.

[dd32]

dare I say we should attempt to introduce array||comma separated notation whenever changes like this area made?

(But yes, this is a 3.3 thing)

[solarissmoke]

Second patch accepts arrays as well. While writing this I noticed that there was a bug in get_boundary_post() - $excluded_categories was being reset to an empty array so it would never exclude anything. Seems nobody uses that feature, otherwise they would have noticed..

[solarissmoke]

Accept arrays as well as comma-separated strings

[dd32]

I'd change that check to if ( !is_array($excluded_categories) ) for 2 reasons, is_string() will return false for ints, and, it's best to check to see if something is not in the expected form and process (in turn, casting to string magically by php) parsing the inputs.

[solarissmoke]

dd32: done - I'll keep that in mind for future also.

[kawauso]

Everyone's favourite bug is coming up for its 7th birthday!

[ryan]

In [18477]:

Support an array or comma-seperated list of excluded category IDs in get_adjacent_post(). Props solarissmoke. fixes #17673

[nacin]

Let's _deprecated_argument() that.

[nacin]

In [18478]:

Fire _deprecated_argument() for get_adjacent_post()'s crazy excluded_categories 'and' thing. fixes #17673.

[SergeyBiryukov]

In 45033:

Docs: Correct back-compat reference to $excluded_categories in get_adjacent_post().

See #46543, #17673.