Notice: Trying to get property of non-object in /wp-admin/includes/template.php on line 1856

[greuben]

Login as an author to reproduce

[ryan]

In [18135]:

Check result of add_theme_page(). Return if false. Props greuben. fixes #17677

[ryan]

Did it a bit differently just in case we add anything else to that function.

[nacin]

In [18136]:

Document that add_submenu_page() might return false if ! current_user_can(). see #17677.

[nacin]

add_menu_page() and friends does not return false in this case. Can anyone think of a reason why?

[greuben]

add_menu_page() and friends does not return false in this case. Can anyone think of a reason why?

Maybe because top level menus should always exist to show low cap level menus if any.

add_action( 'admin_menu', function(){
	add_menu_page( 'test', 'test', 'manage_options', 'test', '__return_false' );
	add_submenu_page( 'test', 'test-2', 'test-2', 'read', 'test2', '__return_false' );
} );