Nav menu "Add to menu" buttons should be disabled if they're actually non-functional

[mitchoyoshitaka]

Nav menu "add to menu" buttons currently stay enabled, or enabled-looking, even if no .categorychecklist are checked or if no custom link URL is entered. We should dynamically specify whether that button is enabled or not, based on the options in that postbox.

[saracannon]

This. Is. Awesome.

[melchoyce]

Just tested, still an issue. I'm a +1 to doing this. Maybe a decent good-first-bug, even though there's already a patch? Could maybe just need a refresh.

[xkon]

Updated to current nav-menu.js and fixed to work properly with current code.

[xkon]

Updated the diff ( 17698.1.diff ) to the current js file. Also changed it a bit to also have the Select All working by enabling/disabling the Add To Menu accordingly.

An extra thing I want to point out is that as the page doesn't refresh the Add to Menu button will stay enabled after a user adds a page. This is nice because the user won't lose focus off that button so it's easier to tab back and forth to add more pages if he wishes instead of tabbing all the way back to the Accordion menu.

Need some feedback from the accessibility team as well to tell me what they think about the button staying active after the page is added.

Best regards,
Konstantinos

[melchoyce]

Looks good from a flow standpoint 👍

[xkon]

Update to Coding Standards.

[xkon]

Fixed the 17698.2.diff for tabs etc as my editor had some issues the last time.

Best regards,
Konstantinos

[boemedia]

UX feedback was already given by @melchoyce , so removing that tag. We do think this needs some code and accessibility reviewing though.

[afercia]

As noted in the ​Gutenberg Phase 2 post, the wp-admin Menus screen will be reworked to use Blocks to build menus.

Exploration is still ongoing but from the early mockups (see GitHub issue below) it's pretty clear the entire "Add to menu" section will be replaced with a sort of "Inserter", like in Gutenberg.

Admin Menus screen:
​https://github.com/WordPress/gutenberg/issues/13206

Navigation Block:
​https://github.com/WordPress/gutenberg/issues/1466

As the user interface will drastically change, I'm going to close this ticket as "wontfix". Sorry for the lack of a more proper keyword (a "replaced by" keyword would be more appropriate). Thanks everyone for the explorations and patches here, please do feel free to reopen if I'm missing something.