WordPress.org

Make WordPress Core

Opened 6 years ago

Last modified 5 weeks ago

#17698 reviewing enhancement

Nav menu "Add to menu" buttons should be disabled if they're actually non-functional

Reported by: mitchoyoshitaka Owned by: koopersmith
Milestone: Awaiting Review Priority: normal
Severity: normal Version: 3.0
Component: Menus Keywords: has-patch ux-feedback needs-testing
Focuses: ui, accessibility Cc:

Description

Nav menu "add to menu" buttons currently stay enabled, or enabled-looking, even if no .categorychecklist are checked or if no custom link URL is entered. We should dynamically specify whether that button is enabled or not, based on the options in that postbox.

Attachments (3)

17698.diff (2.0 KB) - added by mitchoyoshitaka 6 years ago.
17698.1.diff (3.3 KB) - added by xkon 5 weeks ago.
Updated to current nav-menu.js and fixed to work properly with current code.
17698.2.diff (2.8 KB) - added by xkon 5 weeks ago.
Update to Coding Standards.

Download all attachments as: .zip

Change History (16)

#1 @saracannon
6 years ago

  • Cc sararcannon@… added

This. Is. Awesome.

#2 @nacin
6 years ago

  • Owner set to koopersmith
  • Status changed from new to reviewing
  • Type changed from defect (bug) to enhancement
  • Version changed from 3.2 to 3.0

#3 @c3mdigital
4 years ago

  • Keywords needs-refresh added

#4 @helen
4 years ago

  • Keywords ui-focus added

#5 @chriscct7
23 months ago

  • Keywords ux-feedback added
  • Severity changed from trivial to normal

This ticket was mentioned in Slack in #design by karmatosed. View the logs.


5 weeks ago

#7 @melchoyce
5 weeks ago

Just tested, still an issue. I'm a +1 to doing this. Maybe a decent good-first-bug, even though there's already a patch? Could maybe just need a refresh.

This ticket was mentioned in Slack in #accessibility by xkon. View the logs.


5 weeks ago

@xkon
5 weeks ago

Updated to current nav-menu.js and fixed to work properly with current code.

#9 @xkon
5 weeks ago

  • Focuses accessibility added
  • Keywords needs-testing added; needs-refresh removed

Updated the diff ( 17698.1.diff ) to the current js file. Also changed it a bit to also have the Select All working by enabling/disabling the Add To Menu accordingly.

An extra thing I want to point out is that as the page doesn't refresh the Add to Menu button will stay enabled after a user adds a page. This is nice because the user won't lose focus off that button so it's easier to tab back and forth to add more pages if he wishes instead of tabbing all the way back to the Accordion menu.

Need some feedback from the accessibility team as well to tell me what they think about the button staying active after the page is added.

Best regards,
Konstantinos

This ticket was mentioned in Slack in #design by xkon. View the logs.


5 weeks ago

This ticket was mentioned in Slack in #design by melchoyce. View the logs.


5 weeks ago

#12 @melchoyce
5 weeks ago

Looks good from a flow standpoint 👍

@xkon
5 weeks ago

Update to Coding Standards.

#13 @xkon
5 weeks ago

Fixed the 17698.2.diff for tabs etc as my editor had some issues the last time.

Best regards,
Konstantinos

Note: See TracTickets for help on using tickets.