WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#17706 closed defect (bug) (fixed)

removeAttr('style') to fix #17058 does not work in Chromium

Reported by: duck_ Owned by: azaozz
Milestone: 3.2 Priority: normal
Severity: normal Version: 3.2
Component: Menus Keywords: has-patch
Focuses: Cc:

Description

The second part of #17058, unable to view submenu on hover after toggling closed and collapsing the menu, is not fixed for Chrom(ium|e).

This is because removeAttribute('style'), used internally by the jQuery removeAttr() function, does not work properly in said browser. Tested using Chromium 11.0.696.71 on Linux.

http://jsfiddle.net/q35F9/2/

http://code.google.com/p/chromium/issues/detail?id=80670

http://code.google.com/p/chromium/issues/detail?id=35751

Strangely if you try to observe the behaviour as it happens using the inbuilt developer tools it works as expected. You can only check that "display:none;" is still set after toggling the submenu closed.

An alternative method I thought of to fix this was to use .css('display',''). This works in both Chromium and Firefox in testing. Any other methods?

Note that the first part of #17058 isn't an issue since submenus are hidden by width = 0 when the menu is collapsed.

Related: #17058, r17623

Attachments (1)

17706.diff (551 bytes) - added by duck_ 3 years ago.

Download all attachments as: .zip

Change History (3)

duck_3 years ago

comment:1 azaozz3 years ago

  • Owner set to azaozz
  • Resolution set to fixed
  • Status changed from new to closed

In [18170]:

Workaround for removeAttr('style') in Chromium, props duck_, fixes #17706

comment:2 azaozz3 years ago

  • Milestone changed from Awaiting Review to 3.2
Note: See TracTickets for help on using tickets.