WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 16 months ago

#17714 closed defect (bug) (invalid)

Comment/pingback handlers don't check whether the post type supports comments

Reported by: solarissmoke Owned by:
Milestone: Priority: normal
Severity: normal Version: 3.1
Component: Comments Keywords: dev-feedback
Focuses: Cc:

Description

wp-comments-post and XML-RPC don't check post type support for comments before accepting them - I think they should. We can't rely solely on $post->comment_status because that may not always be set to "closed" even if the post type doesn't support comments (see also #13473)

Maybe we could add a check to comments_open()?

Change History (3)

#1 follow-up: @nacin
5 years ago

Would require #17568.

I don't know if the lack of a supported UI for comments (which is what 'supports' means across the board) means that wp-comments-post.php should not be able to accept comments.

#2 @chriscct7
16 months ago

  • Keywords dev-feedback added

#3 in reply to: ↑ 1 @DrewAPicture
16 months ago

  • Keywords 2nd-opinion removed
  • Milestone Awaiting Review deleted
  • Resolution set to invalid
  • Status changed from new to closed

Replying to nacin:

Would require #17568.

I don't know if the lack of a supported UI for comments (which is what 'supports' means across the board) means that wp-comments-post.php should not be able to accept comments.

I agree.

Note: See TracTickets for help on using tickets.