WordPress.org
Get WordPress

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #17748, comment 25


Ignore:
Timestamp:
06/13/2011 05:07:30 AM (13 years ago)
Author:
dd32
Comment:

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #17748, comment 25

    initial v1  
    11Summery of pending changes here:
    2  * Coding - Theme has to check {{{get_option('page_comments')}}} in order to determine if comment paging is enabled as get_comment_pages_count() returns > 1 when paging is disabled. See #17778
    3  * String change - s/<b>/<strong>/g ? comment:3
    4  * String change - CPT & Categories missing from their "posted in" line, comment:20
    5  * UI - Image Post Format footer style, comment:18 features a different style and colour: [http://dd32.id.au/files/wordpress/temp/2011--footercolourstyle.jpg 2011--footercolourstyle.jpg]
     2 1. Coding - Theme has to check {{{get_option('page_comments')}}} in order to determine if comment paging is enabled as get_comment_pages_count() returns > 1 when paging is disabled. See #17778
     3 2. String change - s/<b>/<strong>/g ? comment:3
     4 3. String change - CPT & Categories missing from their "posted in" line, comment:20
     5 4. UI - Image Post Format footer style, comment:18 features a different style and colour: [http://dd32.id.au/files/wordpress/temp/2011--footercolourstyle.jpg 2011--footercolourstyle.jpg]
    66   * Background Colour
    77   * Date in the footer for the image, Posted In & Leave reply have a separator on other types, here, it's a new line
    88   * Has Different Link colour in order to fit in with background colour
    99   * Edit link can probably float on the same line even
    10  * UI - Status/Aside title vs. content mis-matches in different places comment:1 comment:2
    11  * CSS/UI - Comment reply button is not aligned consistantly, comment:11 [http://dd32.id.au/files/wordpress/temp/2011-commentreplymisaligned.jpg 2011-commentreplymisaligned.jpg]
     10 5. UI - Status/Aside title vs. content mis-matches in different places comment:1 comment:2
     11 6. CSS/UI - Comment reply button is not aligned consistantly, comment:11 [http://dd32.id.au/files/wordpress/temp/2011-commentreplymisaligned.jpg 2011-commentreplymisaligned.jpg]
    1212
    1313If other devs can weigh in here on their expected/preferred outcome on those points, it'd be appreciated as I'm not too fussed about which way they all go, The UI ones just don't feel right to me, but that's not my area of expertise :) (''Just ship it! '' isn't what i'd like to hear either ;))