WordPress.org

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #17748, comment 3


Ignore:
Timestamp:
06/11/11 05:39:27 (3 years ago)
Author:
dd32
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #17748, comment 3

    initial v1  
    1  * showcase.php - [http://core.trac.wordpress.org/browser/trunk/wp-content/themes/twentyeleven/showcase.php#L131 Requeries $featured_args] for no apparent reason 
    2  * showcase.php - uses a counter to output a list, could just do an if and then a while. Also leaves a </ol> stranded if there are no posts.. which is unlikely 
     1 * ~~showcase.php - [http://core.trac.wordpress.org/browser/trunk/wp-content/themes/twentyeleven/showcase.php#L131 Requeries $featured_args] for no apparent reason~~ 
     2 * ~~ showcase.php - uses a counter to output a list, could just do an if and then a while. Also leaves a </ol> stranded if there are no posts.. which is unlikely~~ 
    33 * showcase.php - {{{s/<b>/<strong>/g}}} ? (in the Commenting strings) 
    4  * showcase.php again - {{{$xx = new WP_Query(); $xx->query($args);  =>  $xx = new WP_Query( $args );}}} 
     4 * ~~showcase.php again - {{{$xx = new WP_Query(); $xx->query($args);  =>  $xx = new WP_Query( $args );}}}~~ 
    55 
    66I'm not coding everything as I run across it to avoid stomping on feet and leaving a huge patch on someones morning email, I'm happy to deal with most of the changes here if someone would like to confirm the expected behaviour on most of the items. Unless there are any objections, I'll work on a patch for cleaning up the PHP tomorrow (ie. 12hours from now) which is separate from the consistency issues outlined above.