WordPress.org
Get WordPress

Make WordPress Core

Changes between Version 18 and Version 26 of Ticket #17748


Ignore:
Timestamp:
06/13/2011 05:35:44 AM (14 years ago)
Author:
dd32
Comment:

Another one:

  1. UI / String - Edit link, (Edit) for pingbacks, [Edit] for Comments, and Edit (with a grey rounded rectangle background) for Posts/Attachments and CPT's
    • Merge strings? Go for all Edit, or just merge the Comment/Pingback ones to [Edit]
    • If merge all, leaves us with a styling issue, I vote to style them the same as Post Edit links and float to the upper right of the comment. See ​2011-comments.jpg
    • The edit link in archive views is in the Lower left, In singular views it's in the Upper Right.
    • The edit link for Pages is a plain link at the bottom of the content, rather than the grey rectangle in the upper left.
  2. Child comments have the Author on it's own line, See ​2011-comments.jpg again for that, Single line leaves whitespace however.

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #17748 – Description

    v18 v26  
    44 * ~~ archive.php - doesnt need to call the_post(); only uses global query conditionals.~~
    55 * ~~ author.php - comment typo~~
    6  * comments.php - has to check get_option( 'page_comments' ) ? Shouldn't that be included within get_comment_pages_count() instead to short-circuit it?
     6 * ~~ comments.php - has to check get_option( 'page_comments' ) ? Shouldn't that be included within get_comment_pages_count() instead to short-circuit it? ~~ See #17778
    77 * ~~ content-aside.php, content-link.php, content-image.php, content-quote.php,  - use get_post_type() instead of $post->post_type~~
    88 * ~~ content-gallery.php - indentation (trivial I know)~~
    … …  
    1010 * content-single.php doesnt have a post = post_type conditional on date meta like most of the rest of the content items.
    1111 * ~~ content-status.php - Dead code, and avoid using the post type itself~~
    12  * content.php - ~~Applies to most files, using 'echo=0' on a few items,~~ $show_sep code is rather convuluted as well, perhaps appending to an array and imploding it would be cleaner, This style of code is used in a few places, but not all.
     12 * content.php - ~~Applies to most files, using 'echo=0' on a few items, $show_sep code is rather convuluted as well, perhaps appending to an array and imploding it would be cleaner, This style of code is used in a few places, but not all.~~ $show_sep is stuck there for the time being, array+imploding can't be done with all of the meta's due to echo-only items. Strcuture/indentation could clean it up
    1313 * ~~image.php - Has verbose Comments vs. Trackbacks being closed text, This text isnt used on other pages, only mention of Trackbacks are on this template too~~
    1414 * ~~inc/theme-options.php - Use $hook_suffix within an hook name instead of attaching to the generic action~~