Changes between Initial Version and Version 9 of Ticket #17748
- Timestamp:
- 06/11/2011 03:59:54 AM (14 years ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
Ticket #17748
- Property Owner set to azaozz
-
Property
Status
changed from
newtoreopened
-
Ticket #17748 – Description
initial v9 2 2 3 3 attached is a diff of problems which I'm going to walk through: 4 * archive.php - doesnt need to call the_post(); only uses global query conditionals.5 * author.php - comment typo4 * ~~ archive.php - doesnt need to call the_post(); only uses global query conditionals.~~ 5 * ~~ author.php - comment typo~~ 6 6 * comments.php - has to check get_option( 'page_comments' ) ? Shouldn't that be included within get_comment_pages_count() instead to short-circuit it? 7 * content-aside.php, content-link.php, content-image.php, content-quote.php, - use get_post_type() instead of $post->post_type8 * content-gallery.php - indentation (trivial I know)7 * ~~ content-aside.php, content-link.php, content-image.php, content-quote.php, - use get_post_type() instead of $post->post_type~~ 8 * ~~ content-gallery.php - indentation (trivial I know)~~ 9 9 * content-image.php & a few others - Doesnt use {{{<span class="sep"> | </span>}}} between utility entries? 10 10 * content-single.php doesnt have a post = post_type conditional on date meta like most of the rest of the content items. 11 * content-status.php - Dead code, and avoid using the post type itself12 * content.php - Applies to most files, using 'echo=0' on a few items,$show_sep code is rather convuluted as well, perhaps appending to an array and imploding it would be cleaner, This style of code is used in a few places, but not all.11 * ~~ content-status.php - Dead code, and avoid using the post type itself~~ 12 * content.php - ~~Applies to most files, using 'echo=0' on a few items,~~ $show_sep code is rather convuluted as well, perhaps appending to an array and imploding it would be cleaner, This style of code is used in a few places, but not all. 13 13 * image.php - Has verbose Comments vs. Trackbacks being closed text, This text isnt used on other pages, only mention of Trackbacks are on this template too 14 * inc/theme-options.php - Use $hook_suffix within an hook name instead of attaching to the generic action15 * single.php() - Dead code14 * ~~inc/theme-options.php - Use $hook_suffix within an hook name instead of attaching to the generic action~~ 15 * ~~single.php() - Dead code~~ 16 16 17 17 Most of this really just needs a sanity check on what is supposed to apply, and apply it to the rest of the template files.