WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#17757 closed defect (bug) (fixed)

Press This metaboxes do not conform to new standard style

Reported by: duck_ Owned by: koopersmith
Milestone: 3.2 Priority: normal
Severity: normal Version: 3.2
Component: Press This Keywords: has-patch
Focuses: Cc:

Description

See title.

Tag box has a different class compared to the normal post screen so that fixes that mostly. Also updated the toggle background image.

Unfixed:

  • the bottom of the box headers appears to have a border issue
  • when collapsed it looks as if the boxes do not have rounded bottom corners (not entirely sure)

And anything else that I didn't notice straight away.

Attachments (4)

17757.diff (1.0 KB) - added by duck_ 3 years ago.
17757.2.diff (11.0 KB) - added by koopersmith 3 years ago.
17757.3.diff (11.4 KB) - added by koopersmith 3 years ago.
17757.rtl.patch (1.7 KB) - added by ocean90 3 years ago.

Download all attachments as: .zip

Change History (16)

duck_3 years ago

comment:1 koopersmith3 years ago

  • Owner set to koopersmith
  • Status changed from new to accepted

koopersmith3 years ago

koopersmith3 years ago

comment:2 koopersmith3 years ago

It still needs a little tweaking, but this should cover most of it.

comment:3 koopersmith3 years ago

  • Keywords has-patch added

comment:4 nacin3 years ago

That'll probably need RTL.

comment:5 azaozz3 years ago

  • Component changed from General to Press This
  • Keywords commit added

17757.3 looks good.

comment:6 nacin3 years ago

Only thing I notice is the persistent underline under the blog title, rather than just on hover.

comment:7 nacin3 years ago

  • Keywords needs-patch rtl-feedback added; has-patch commit removed

RTL doesn't need much here at all.

comment:8 nacin3 years ago

In [18279]:

UI refresh for Press This. props koopersmith, see #17757.

ocean903 years ago

comment:9 ocean903 years ago

  • Keywords has-patch added; needs-patch rtl-feedback removed

comment:10 nacin3 years ago

Only thing I see is that 'All Categories' and 'Most Used' should probably be on the right.

comment:11 azaozz3 years ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In [18282]:

Press This RTL css fixes, props ocean90, fixes #17757

comment:12 azaozz3 years ago

In [18283]:

More Press This cleanup and fixes, see #17757

Note: See TracTickets for help on using tickets.