WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

#17758 closed defect (bug) (fixed)

inconsistent white space between manage/install theme tabs

Reported by: trepmal Owned by: nacin
Milestone: 3.2 Priority: normal
Severity: minor Version: 3.2
Component: General Keywords:
Focuses: Cc:

Description

http://cl.ly/7W0T/themes-admin.jpg

Due to some white space, the tabs sit slightly farther apart on the Manage Themes page.

theme-install.php also using a is_network_admin() - I don't see how that would ever return true, since the network admin has its own theme-install.php.

Attachments (2)

theme-install.diff (994 bytes) - added by trepmal 5 years ago.
theme-install.2.diff (772 bytes) - added by trepmal 5 years ago.
white space only

Download all attachments as: .zip

Change History (6)

#1 @ocean90
5 years ago

I don't see how that would ever return true, since the network admin has its own theme-install.php.


It requires the file:

require( '../theme-install.php' );

#2 @nacin
5 years ago

  • Keywords needs-patch added; has-patch removed

Can you refresh the patch so it just touches the white space?

ocean90 is right, the network admin piggybacks on non-network admin files in a lot of situations.

#3 @nacin
5 years ago

  • Keywords needs-patch removed
  • Milestone changed from Awaiting Review to 3.2

Found another inconsistency, where if you don't have install_themes cap, we still show a single tab on themes.php.

Fixing that now and reducing the space on that page, rather than widening it on theme-install.php.

@trepmal
5 years ago

white space only

#4 @nacin
5 years ago

  • Owner set to nacin
  • Resolution set to fixed
  • Status changed from new to closed

In [18248]:

Fix whitespace discrepancy between Manage Themes and Install Themes tabs. props trepmal. Don't show a single Manage Themes heading as a tab if the user doesn't have install_themes. fixes #17758.

Note: See TracTickets for help on using tickets.