Context Navigation

← Previous Ticket
Next Ticket →

#17758 closed defect (bug) (fixed)

inconsistent white space between manage/install theme tabs

Reported by:	trepmal	Owned by:	nacin
Priority:	normal	Milestone:	3.2
Component:	General	Version:	3.2
Severity:	minor	Keywords:
Cc:		Focuses:

Description

Due to some white space, the tabs sit slightly farther apart on the Manage Themes page.

theme-install.php also using a is_network_admin() - I don't see how that would ever return true, since the network admin has its own theme-install.php.

Attachments (2)

theme-install.diff (994 bytes ) - added by trepmal 15 years ago.
theme-install.2.diff (772 bytes ) - added by trepmal 15 years ago.: white space only

Download all attachments as: .zip

Change History (6)

@trepmal
15 years ago

Attachment theme-install.diff added

#1 @ocean90
15 years ago

I don't see how that would ever return true, since the network admin has its own theme-install.php.

It requires the file:

require( '../theme-install.php' );

#2 @nacin
15 years ago

Keywords needs-patch added; has-patch removed

Can you refresh the patch so it just touches the white space?

ocean90 is right, the network admin piggybacks on non-network admin files in a lot of situations.

#3 @nacin
15 years ago

Keywords needs-patch removed
Milestone Awaiting Review → 3.2

Found another inconsistency, where if you don't have install_themes cap, we still show a single tab on themes.php.

Fixing that now and reducing the space on that page, rather than widening it on theme-install.php.

@trepmal
15 years ago

Attachment theme-install.2.diff added

white space only

#4 @nacin
15 years ago

Owner set to nacin
Resolution → fixed
Status new → closed

In [18248]:

Fix whitespace discrepancy between Manage Themes and Install Themes tabs. props trepmal. Don't show a single Manage Themes heading as a tab if the user doesn't have install_themes. fixes #17758.

Note: See TracTickets for help on using tickets.

Download in other formats:

Make WordPress Core

Context Navigation

#17758 closed defect (bug) (fixed)

inconsistent white space between manage/install theme tabs

Description

Attachments (2)

Change History (6)

@trepmal 15 years ago

#1 @ocean90 15 years ago

#2 @nacin 15 years ago

#3 @nacin 15 years ago

@trepmal 15 years ago

#4 @nacin 15 years ago

Download in other formats:

@trepmal
15 years ago

#1 @ocean90
15 years ago

#2 @nacin
15 years ago

#3 @nacin
15 years ago

@trepmal
15 years ago

#4 @nacin
15 years ago