Opened 13 years ago
Closed 13 years ago
#17765 closed defect (bug) (fixed)
Browser update nag text unreadable
| Reported by: |
|
Owned by: |
|
|---|---|---|---|
| Milestone: | 3.2 | Priority: | normal |
| Severity: | normal | Version: | 3.2 |
| Component: | Administration | Keywords: | has-patch |
| Focuses: | Cc: |
Description
The text in the browser update dashboard box is unreadable as it's white on grey.
Attachments (4)
Change History (9)
#2
@
13 years ago
- Milestone changed from Awaiting Review to 3.2
Looks like our background color has been overridden.
#3
follow-up:
↓ 4
@
13 years ago
- Keywords has-patch added
Patch attached.
Some other minor items. These styles are duplicated between the two admin colour schemes. Couldn't they be in dashboard.css? We also seem to be inconsistent about lower case colour hex codes and upper case (I was under the impression the standard was for lower case).
#4
in reply to:
↑ 3
@
13 years ago
Replying to duck_:
Some other minor items. These styles are duplicated between the two admin colour schemes. Couldn't they be in dashboard.css? We also seem to be inconsistent about lower case colour hex codes and upper case (I was under the impression the standard was for lower case).
Added patches for these. Separated them out so it's easier to cherry pick the favoured option.
Colour hex codes are supposed to be lower case according to CSS Coding Standards.
I don't see an issue with having the colours in dashboard.css since they're the same for both colour schemes, as well as for custom colour schemes I suppose. There are already colours specified in dashboard.css.
17765.diff: fixes the issue the ticket was made for
17765.lower-case.diff: as above and also converts to lower case hex codes
17765.movetodashboard.css.diff: as above and also moves browser nag styles to dashboard.css
At r18275