WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 4 years ago

#17765 closed defect (bug) (fixed)

Browser update nag text unreadable

Reported by: johnbillion Owned by: nacin
Milestone: 3.2 Priority: normal
Severity: normal Version: 3.2
Component: Administration Keywords: has-patch
Focuses: Cc:

Description

The text in the browser update dashboard box is unreadable as it's white on grey.

Attachments (4)

capture.png (45.2 KB) - added by johnbillion 4 years ago.
17765.diff (1.1 KB) - added by duck_ 4 years ago.
17765.lower-case.diff (3.4 KB) - added by duck_ 4 years ago.
17765.movetodashboard.css.diff (5.4 KB) - added by duck_ 4 years ago.

Download all attachments as: .zip

Change History (9)

@johnbillion4 years ago

comment:1 @johnbillion4 years ago

  • Version set to 3.2

At r18275

comment:2 @nacin4 years ago

  • Milestone changed from Awaiting Review to 3.2

Looks like our background color has been overridden.

@duck_4 years ago

comment:3 follow-up: @duck_4 years ago

  • Keywords has-patch added

Patch attached.

Some other minor items. These styles are duplicated between the two admin colour schemes. Couldn't they be in dashboard.css? We also seem to be inconsistent about lower case colour hex codes and upper case (I was under the impression the standard was for lower case).

@duck_4 years ago

comment:4 in reply to: ↑ 3 @duck_4 years ago

Replying to duck_:

Some other minor items. These styles are duplicated between the two admin colour schemes. Couldn't they be in dashboard.css? We also seem to be inconsistent about lower case colour hex codes and upper case (I was under the impression the standard was for lower case).

Added patches for these. Separated them out so it's easier to cherry pick the favoured option.

Colour hex codes are supposed to be lower case according to CSS Coding Standards.

I don't see an issue with having the colours in dashboard.css since they're the same for both colour schemes, as well as for custom colour schemes I suppose. There are already colours specified in dashboard.css.

17765.diff: fixes the issue the ticket was made for

17765.lower-case.diff: as above and also converts to lower case hex codes

17765.movetodashboard.css.diff: as above and also moves browser nag styles to dashboard.css and changes some instances of #dashboard-widgets to #dashboard_browser_nag for browser nag specific styles previously in dashboard.css

Last edited 4 years ago by duck_ (previous) (diff)

comment:5 @nacin4 years ago

  • Owner set to nacin
  • Resolution set to fixed
  • Status changed from new to closed

In [18278]:

Fix display of browser nag, use lowercase hex values, move identical styles out of colors-* and into dashboard.css. props duck_, fixes #17765.

Note: See TracTickets for help on using tickets.