Make WordPress Core

Opened 13 years ago

Closed 10 years ago

#17766 closed enhancement (wontfix)

Browser update dismiss button lacks non-JavaScript fallback

Reported by: johnbillion's profile johnbillion Owned by:
Milestone: Priority: normal
Severity: minor Version: 3.2
Component: Administration Keywords: needs-patch
Focuses: Cc:

Description

The 'Dismiss' button in the browser update dashboard box doesn't do its thing without JavaScript enabled.

Attachments (1)

17766.hide-if-no-js.diff (806 bytes) - added by duck_ 13 years ago.

Download all attachments as: .zip

Change History (10)

#1 @nacin
13 years ago

  • Milestone changed from Awaiting Review to 3.2

#2 @duck_
13 years ago

  • Keywords has-patch 2nd-opinion added

Simple approach of not allowing a dismiss if JavaScript is disabled.

For: None of the other metaboxes can be hidden. It's simple.

Against: The browser nag takes a high priority position and cannot be moved without JS, could be annoying for user who is forced to use an old browser without JS (not sure how likely this scenario is).

#3 @aaroncampbell
13 years ago

I'd say that's a sane solution. Without JS they can't hide any meta boxes, so I don't think they'll be expecting to be able to hide this one.

#4 @ocean90
13 years ago

  • Keywords 2nd-opinion removed

Good enough for now.

#5 @nacin
13 years ago

We already annoy them enough on the dashboard if they have JS disabled. How challenging would it be to make this work without JS?

#6 @nacin
13 years ago

In [18281]:

Browser nag dismiss: hide-if-no-js. props duck_, see #17766.

#7 @nacin
13 years ago

  • Keywords needs-patch added; has-patch removed
  • Milestone changed from 3.2 to Future Release

In line with #13516, let's make this a little less painful in the future.

Moved the class to the paragraph in the commit. Thanks duck_.

#8 @hakre
13 years ago

Related: #18530

#9 @johnbillion
10 years ago

  • Milestone Future Release deleted
  • Resolution set to wontfix
  • Status changed from new to closed

I don't think anybody cares enough about this for it to ever get done. Re-open if someone wants to do it.

Note: See TracTickets for help on using tickets.