WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 3 years ago

#17770 closed defect (bug) (fixed)

Fix misspelling and minor formatting in emails

Reported by: dcowgill Owned by: nacin
Milestone: 3.3 Priority: normal
Severity: normal Version: 3.2
Component: Mail Keywords: has-patch
Focuses: Cc:

Description

To be consistent with other emails found in schema.php, upgrade.php, & ms-functions.php.

Attachments (2)

17770.diff (928 bytes) - added by dcowgill 3 years ago.
17770.patch (534 bytes) - added by SergeyBiryukov 3 years ago.

Download all attachments as: .zip

Change History (11)

dcowgill3 years ago

comment:1 dcowgill3 years ago

  • Keywords has-patch added; needs-patch removed

comment:2 nacin3 years ago

  • Milestone changed from Awaiting Review to 3.2

Login is not a verb. Thanks!

What's the purpose of moving "Thanks!" up a line? Is that for consistency?

comment:3 dcowgill3 years ago

Then "Log in Here" should probably be changed to "Login Here" in /wp-admin/includes/schema.php (line 692)

"Thanks!" was moved up to match wp_new_blog_notification in /wp-admin/includes/upgrade.php (line 331)

Obviously not major stuff here - just trying to be consistent. :-)

comment:4 nacin3 years ago

I meant that Login is wrong, and the correct is Log in.

comment:5 nacin3 years ago

  • Owner set to nacin
  • Resolution set to fixed
  • Status changed from new to closed

In [18287]:

Login is not a verb. props dcowgill, fixes #17770.

comment:6 nacin3 years ago

In [18289]:

Login is not a verb. props dcowgill, fixes #17770.

comment:7 follow-up: nacin3 years ago

Also [18288].

I left the "Thanks" as is in wp-admin/includes/schema.php as the "Log in" was correct, no reason to break a string this late in the cycle.

SergeyBiryukov3 years ago

comment:8 in reply to: ↑ 7 SergeyBiryukov3 years ago

  • Milestone changed from 3.2 to 3.3
  • Resolution fixed deleted
  • Status changed from closed to reopened

Replying to nacin:

I left the "Thanks" as is in wp-admin/includes/schema.php as the "Log in" was correct, no reason to break a string this late in the cycle.

That string and the one in ms-functions.php are exactly the same, aside from the line break and "Log in Here"/"Log in here". I guess we can merge them in 3.3. Attaching a patch.

comment:9 ryan3 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In [18878]:

Syncronize some strings. Props dcowgill, SergeyBiryukov. fixes #17770

Note: See TracTickets for help on using tickets.