WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#17781 closed defect (bug) (fixed)

Browser nag messed up in dashboard

Reported by: jane Owned by: nacin
Milestone: 3.2 Priority: normal
Severity: normal Version: 3.2
Component: UI Keywords:
Focuses: Cc:

Description

A fix went in to make sure the browser nag would stay in upper corner of dashboard (vs showing up at bottom of column), but the fix is broken. Seems to be wrapping entire second column in the orange/yellow background, dumped 2nd column below 1st, and footer is appearing before column ends. See screenshot.

Attachments (2)

Screen shot 2011-06-13 at 4.09.11 AM.png (190.9 KB) - added by jane 4 years ago.
Browser nag in Firefox
rtl-browser-ie7.PNG (102.7 KB) - added by ramiy 4 years ago.
ie7 RTL issue

Download all attachments as: .zip

Change History (13)

@jane4 years ago

Browser nag in Firefox

comment:2 @nacin4 years ago

  • Owner set to nacin
  • Resolution set to fixed
  • Status changed from new to closed

In [18297]:

[18294] was a bit too quick to eliminate backslashed apostrophes in translated strings. $s as a placeholder becomes a variable. Switch to %s and %s, as the href will always come before the text, so no need for numbered placeholders. fixes #17781.

comment:3 @jane4 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

The fix to the fix bumped the nag back to the bottom of column 1.

comment:4 @nacin4 years ago

Hmm. I see it at the top here. I imagine the original fix didn't account for all cases. azaozz will need to take a look tonight.

comment:5 @dd324 years ago

The fix to the fix bumped the nag back to the bottom of column 1.

For what It's worth, It wasn't the fix that bumped it back there.

I replicated that earlier, On an install that I had rearranged the metaboxes whilst the browser nag was active, the nag got stuck to the bottom of col1, on a "new" install that i hadn't touched the metaboxes on, it was forced into upper left position.

comment:6 @jane4 years ago

@dd32: Yes, that's what we guessed last night. Ozz's fix was meant to put it up top even if boxes had been rearranged before.

comment:7 @nacin4 years ago

After looking at this for a long while and attempting a number of iterations, I've realized we can simply force the browser nag into the 'high' priority, which is otherwise unused on the dashboard.

comment:8 @nacin4 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In [18314]:

Anchor the Browse Happy dashboard widget to the top. Reverts [18295], [18296]. Fixes #17781, #17323.

comment:9 @nacin4 years ago

That should have noted the revert only covers the PHP bits of [18295] and [18296]. Though, the braces added in [18296] now remain, for readability purposes.

@ramiy4 years ago

ie7 RTL issue

comment:10 @nacin4 years ago

ramiy: Attachments do not trigger notifications. I just happened to notice this. Please open a new ticket.

comment:11 @nacin4 years ago

In [18320]:

Don't push dashboard_browser_nag into 'sorted' in do_meta_boxes. see #17781.

Note: See TracTickets for help on using tickets.