Browser nag messed up in dashboard

[jane]

A fix went in to make sure the browser nag would stay in upper corner of dashboard (vs showing up at bottom of column), but the fix is broken. Seems to be wrapping entire second column in the orange/yellow background, dumped 2nd column below 1st, and footer is appearing before column ends. See screenshot.

[jane]

Browser nag in Firefox

[nacin]

[18295]

[nacin]

In [18297]:

[18294] was a bit too quick to eliminate backslashed apostrophes in translated strings. $s as a placeholder becomes a variable. Switch to %s and %s, as the href will always come before the text, so no need for numbered placeholders. fixes #17781.

[jane]

The fix to the fix bumped the nag back to the bottom of column 1.

[nacin]

Hmm. I see it at the top here. I imagine the original fix didn't account for all cases. azaozz will need to take a look tonight.

[dd32]

The fix to the fix bumped the nag back to the bottom of column 1.

For what It's worth, It wasn't the fix that bumped it back there.

I replicated that earlier, On an install that I had rearranged the metaboxes whilst the browser nag was active, the nag got stuck to the bottom of col1, on a "new" install that i hadn't touched the metaboxes on, it was forced into upper left position.

[jane]

@dd32: Yes, that's what we guessed last night. Ozz's fix was meant to put it up top even if boxes had been rearranged before.

[nacin]

After looking at this for a long while and attempting a number of iterations, I've realized we can simply force the browser nag into the 'high' priority, which is otherwise unused on the dashboard.

[nacin]

In [18314]:

Anchor the Browse Happy dashboard widget to the top. Reverts [18295], [18296]. Fixes #17781, #17323.

[nacin]

That should have noted the revert only covers the PHP bits of [18295] and [18296]. Though, the braces added in [18296] now remain, for readability purposes.

[ramiy]

ie7 RTL issue

[nacin]

ramiy: Attachments do not trigger notifications. I just happened to notice this. Please open a new ticket.

[nacin]

In [18320]:

Don't push dashboard_browser_nag into 'sorted' in do_meta_boxes. see #17781.